linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@euromail.se>
To: Ping Cheng <pinglinux@gmail.com>
Cc: linux-input <linux-input@vger.kernel.org>
Subject: Re: [PATCH 1/2] input: wacom - Prepare for syncing with input-mt changes
Date: Tue, 4 Dec 2012 19:54:56 +0100	[thread overview]
Message-ID: <20121204185456.GA1728@polaris.bitmath.org> (raw)
In-Reply-To: <CAF8JNhJiLznSSDpzGzcp5CiWfcmGw-idkHX3+XCpvmHdZDKP8g@mail.gmail.com>

> > So the (touch_max > 1) logic replaces the branching on features and device
> > type?
> 
> There are only two types of devices defined for features->device_type:
> BTN_TOOL_PEN and BTN_TOOL_FINGER.
> 
> Once we come to !BTN_TOOL_PEN, we are dealing with touch devices.
> 
> The first if-statement assigns ABS_X/Y for number of contacts less or
> equal to 2. So, it is single and 2 finger touch devices. 2 finger
> touch devices are processed here since they will not use the new
> input_mt_init_slots call, which does not offer benefit to the devices.
> 
> input_mt_init_slots() will take care of ABS_X/Y assignment when flags
> are not zero. All touch devices with more than two contacts will use
> the new input_mt_init_slots call with non-zero flags.
> 
> The second if-statement is for all MT devices, which include two
> finger touch devices.

Great writeup - it could be worth using some of it in the commit
message. :-)

Thanks,
Henrik

  reply	other threads:[~2012-12-04 18:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1354570740-2313-1-git-send-email-pingc@wacom.com>
2012-12-04 16:10 ` [PATCH 1/2] input: wacom - Prepare for syncing with input-mt changes Henrik Rydberg
2012-12-04 17:58   ` Ping Cheng
2012-12-04 18:54     ` Henrik Rydberg [this message]
2012-12-05  2:43 Ping Cheng
2012-12-05 20:18 ` Henrik Rydberg
  -- strict thread matches above, loose matches on Subject: below --
2012-12-01  0:21 Ping Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121204185456.GA1728@polaris.bitmath.org \
    --to=rydberg@euromail.se \
    --cc=linux-input@vger.kernel.org \
    --cc=pinglinux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).