* [PATCH 1/2] Input: xpad - Minor coding style errors fixed.
@ 2012-12-02 6:14 Guillermo A. Amaral
0 siblings, 0 replies; 5+ messages in thread
From: Guillermo A. Amaral @ 2012-12-02 6:14 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: gregkh, linux-input, linux-kernel, Guillermo A. Amaral
From: "Guillermo A. Amaral" <g@maral.me>
Fixed a few minor coding style issues in xpad driver.
Signed-off-by: "Guillermo A. Amaral B." <g@maral.me>
---
drivers/input/joystick/xpad.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 83811e4..3d8f39b 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -235,7 +235,7 @@ static const signed short xpad_abs_triggers[] = {
{ XPAD_XBOX360_VENDOR_PROTOCOL(vend,1) }, \
{ XPAD_XBOX360_VENDOR_PROTOCOL(vend,129) }
-static struct usb_device_id xpad_table [] = {
+static struct usb_device_id xpad_table[] = {
{ USB_INTERFACE_INFO('X', 'B', 0) }, /* X-Box USB-IF not approved class */
XPAD_XBOX360_VENDOR(0x045e), /* Microsoft X-Box 360 controllers */
XPAD_XBOX360_VENDOR(0x046d), /* Logitech X-Box 360 style controllers */
@@ -251,7 +251,7 @@ static struct usb_device_id xpad_table [] = {
{ }
};
-MODULE_DEVICE_TABLE (usb, xpad_table);
+MODULE_DEVICE_TABLE(usb, xpad_table);
struct usb_xpad {
struct input_dev *dev; /* input device interface */
@@ -783,7 +783,7 @@ static int xpad_open(struct input_dev *dev)
struct usb_xpad *xpad = input_get_drvdata(dev);
/* URB was submitted in probe */
- if(xpad->xtype == XTYPE_XBOX360W)
+ if (xpad->xtype == XTYPE_XBOX360W)
return 0;
xpad->irq_in->dev = xpad->udev;
--
1.7.8.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 1/2] Input: xpad - Minor coding style errors fixed.
@ 2012-12-02 7:36 Guillermo A. Amaral
2012-12-04 5:24 ` Dmitry Torokhov
0 siblings, 1 reply; 5+ messages in thread
From: Guillermo A. Amaral @ 2012-12-02 7:36 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: gregkh, linux-input, linux-kernel, Guillermo A. Amaral
From: "Guillermo A. Amaral" <g@maral.me>
Fixed a few minor coding style issues in xpad driver.
Signed-off-by: "Guillermo A. Amaral B." <g@maral.me>
---
drivers/input/joystick/xpad.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 83811e4..3d8f39b 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -235,7 +235,7 @@ static const signed short xpad_abs_triggers[] = {
{ XPAD_XBOX360_VENDOR_PROTOCOL(vend,1) }, \
{ XPAD_XBOX360_VENDOR_PROTOCOL(vend,129) }
-static struct usb_device_id xpad_table [] = {
+static struct usb_device_id xpad_table[] = {
{ USB_INTERFACE_INFO('X', 'B', 0) }, /* X-Box USB-IF not approved class */
XPAD_XBOX360_VENDOR(0x045e), /* Microsoft X-Box 360 controllers */
XPAD_XBOX360_VENDOR(0x046d), /* Logitech X-Box 360 style controllers */
@@ -251,7 +251,7 @@ static struct usb_device_id xpad_table [] = {
{ }
};
-MODULE_DEVICE_TABLE (usb, xpad_table);
+MODULE_DEVICE_TABLE(usb, xpad_table);
struct usb_xpad {
struct input_dev *dev; /* input device interface */
@@ -783,7 +783,7 @@ static int xpad_open(struct input_dev *dev)
struct usb_xpad *xpad = input_get_drvdata(dev);
/* URB was submitted in probe */
- if(xpad->xtype == XTYPE_XBOX360W)
+ if (xpad->xtype == XTYPE_XBOX360W)
return 0;
xpad->irq_in->dev = xpad->udev;
--
1.7.8.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] Input: xpad - Minor coding style errors fixed.
2012-12-02 7:36 [PATCH 1/2] Input: xpad - Minor coding style errors fixed Guillermo A. Amaral
@ 2012-12-04 5:24 ` Dmitry Torokhov
2012-12-04 7:28 ` Guillermo A. Amaral
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Torokhov @ 2012-12-04 5:24 UTC (permalink / raw)
To: Guillermo A. Amaral; +Cc: gregkh, linux-input, linux-kernel
On Sat, Dec 01, 2012 at 11:36:19PM -0800, Guillermo A. Amaral wrote:
> From: "Guillermo A. Amaral" <g@maral.me>
>
> Fixed a few minor coding style issues in xpad driver.
Applied both, thanks Guillermo.
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] Input: xpad - Minor coding style errors fixed.
2012-12-04 5:24 ` Dmitry Torokhov
@ 2012-12-04 7:28 ` Guillermo A. Amaral
2012-12-04 21:10 ` Dmitry Torokhov
0 siblings, 1 reply; 5+ messages in thread
From: Guillermo A. Amaral @ 2012-12-04 7:28 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: gregkh, linux-input, linux-kernel
On Mon, Dec 03, 2012 at 09:24:00PM -0800, Dmitry Torokhov wrote:
> On Sat, Dec 01, 2012 at 11:36:19PM -0800, Guillermo A. Amaral wrote:
> > From: "Guillermo A. Amaral" <g@maral.me>
> >
> > Fixed a few minor coding style issues in xpad driver.
>
> Applied both, thanks Guillermo.
Thanks! Sorry about the double email btw, I thought it failed to send the
first one.
I've getting quite a few gamepad donations for my game console project, so
expect more patches. ;)
Cheers,
G
--
gamaral http://about.me/gamaral
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] Input: xpad - Minor coding style errors fixed.
2012-12-04 7:28 ` Guillermo A. Amaral
@ 2012-12-04 21:10 ` Dmitry Torokhov
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Torokhov @ 2012-12-04 21:10 UTC (permalink / raw)
To: Guillermo A. Amaral; +Cc: gregkh, linux-input, linux-kernel
On Mon, Dec 03, 2012 at 11:28:36PM -0800, Guillermo A. Amaral wrote:
> On Mon, Dec 03, 2012 at 09:24:00PM -0800, Dmitry Torokhov wrote:
> > On Sat, Dec 01, 2012 at 11:36:19PM -0800, Guillermo A. Amaral wrote:
> > > From: "Guillermo A. Amaral" <g@maral.me>
> > >
> > > Fixed a few minor coding style issues in xpad driver.
> >
> > Applied both, thanks Guillermo.
>
> Thanks! Sorry about the double email btw, I thought it failed to send the
> first one.
>
> I've getting quite a few gamepad donations for my game console project, so
> expect more patches. ;)
OK, I will ;)
--
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-12-04 21:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-02 7:36 [PATCH 1/2] Input: xpad - Minor coding style errors fixed Guillermo A. Amaral
2012-12-04 5:24 ` Dmitry Torokhov
2012-12-04 7:28 ` Guillermo A. Amaral
2012-12-04 21:10 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2012-12-02 6:14 Guillermo A. Amaral
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).