From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Kamal Mostafa <kamal@canonical.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Henrik Rydberg <rydberg@euromail.se>,
Dudley Du <dudl@cypress.com>, David Solda <dso@cypress.com>,
Troy Abercrombia <ta@cypress.com>,
Kyle Fazzari <git@status.e4ward.com>,
Mario Limonciello <mario_limonciello@dell.com>,
Tim Gardner <tim.gardner@canonical.com>,
Herton Krzesinski <herton.krzesinski@canonical.com>
Subject: Re: [PATCH v5 1/3] input: increase struct ps2dev cmdbuf[] to 8 bytes
Date: Wed, 5 Dec 2012 23:51:56 -0800 [thread overview]
Message-ID: <20121206075156.GA25921@core.coreip.homeip.net> (raw)
In-Reply-To: <1354752976-27257-2-git-send-email-kamal@canonical.com>
Hi Kamal,
On Wed, Dec 05, 2012 at 04:16:14PM -0800, Kamal Mostafa wrote:
> Cypress PS/2 Trackpad (drivers/input/mouse/cypress_ps2.c) needs
> this larger cmdbuf[] to handle 8-byte packet responses.
>
> Signed-off-by: Kamal Mostafa <kamal@canonical.com>
I will apply this patch so you do not need to resend it with cypress_ps2
patches.
Thanks!
> ---
> include/linux/libps2.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/libps2.h b/include/linux/libps2.h
> index 79603a6..4ad06e8 100644
> --- a/include/linux/libps2.h
> +++ b/include/linux/libps2.h
> @@ -36,7 +36,7 @@ struct ps2dev {
> wait_queue_head_t wait;
>
> unsigned long flags;
> - unsigned char cmdbuf[6];
> + unsigned char cmdbuf[8];
> unsigned char cmdcnt;
> unsigned char nak;
> };
> --
> 1.7.10.4
>
--
Dmitry
next prev parent reply other threads:[~2012-12-06 7:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 0:16 [PATCH v5 0/3] Cypress PS/2 Trackpad driver Kamal Mostafa
2012-12-06 0:16 ` [PATCH v5 1/3] input: increase struct ps2dev cmdbuf[] to 8 bytes Kamal Mostafa
2012-12-06 7:51 ` Dmitry Torokhov [this message]
2012-12-06 0:16 ` [PATCH v5 2/3] input: Cypress PS/2 Trackpad psmouse driver Kamal Mostafa
2012-12-06 8:08 ` Dmitry Torokhov
2012-12-07 2:09 ` Kamal Mostafa
2012-12-06 0:16 ` [PATCH v5 3/3] input: Cypress PS/2 Trackpad link into psmouse-base Kamal Mostafa
2012-12-06 7:52 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206075156.GA25921@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=dso@cypress.com \
--cc=dudl@cypress.com \
--cc=git@status.e4ward.com \
--cc=herton.krzesinski@canonical.com \
--cc=kamal@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario_limonciello@dell.com \
--cc=rydberg@euromail.se \
--cc=ta@cypress.com \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).