From: "Henrik Rydberg" <rydberg@euromail.se>
To: Benson Leung <bleung@chromium.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Daniel Kurtz <djkurtz@chromium.org>,
Olof Johansson <olofj@chromium.org>, Dudley Du <dudl@cypress.com>
Subject: Re: [PATCH v2 1/1] Input: add driver for Cypress APA I2C Trackpad
Date: Sat, 8 Dec 2012 13:39:35 +0100 [thread overview]
Message-ID: <20121208123935.GA3147@polaris.bitmath.org> (raw)
In-Reply-To: <CANLzEkttUr80DX1z-QfqKq8VM0G25m2bTADwU5pUBiB4HAU0Jw@mail.gmail.com>
Hi Benson,
> I have applied your patch, but I found I still need this line in my
> driver, otherwise, there are no ABS type event supported. Should the
> core set this bit as well since it's certainly going to be dealing
> with ABS data?
>
> __set_bit(EV_ABS, input->evbit);
Yes, that would make sense, I will look into it.
> Otherwise, it works great on my Chromebook trackpad here.
Great,
Henrik
next prev parent reply other threads:[~2012-12-08 12:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 22:29 [PATCH] Input: add driver for Cypress APA I2C Trackpad Benson Leung
2012-07-16 11:05 ` Henrik Rydberg
2012-12-06 0:48 ` [PATCH v2 0/1] " Benson Leung
2012-12-06 0:48 ` [PATCH v2 1/1] " Benson Leung
2012-12-06 7:48 ` Dmitry Torokhov
2012-12-06 8:29 ` Jean Delvare
2012-12-06 14:59 ` Henrik Rydberg
2012-12-07 22:52 ` Benson Leung
2012-12-08 12:39 ` Henrik Rydberg [this message]
2012-12-07 23:24 ` [PATCH v3 0/1] " Benson Leung
2012-12-07 23:24 ` [PATCH v3 1/1] " Benson Leung
2012-12-08 12:42 ` Henrik Rydberg
2012-12-13 22:46 ` Benson Leung
2013-01-22 17:57 ` [v3,1/1] " Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121208123935.GA3147@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=bleung@chromium.org \
--cc=djkurtz@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dudl@cypress.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olofj@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).