From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Kamal Mostafa <kamal@canonical.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Dudley Du <dudl@cypress.com>, David Solda <dso@cypress.com>,
Troy Abercrombia <ta@cypress.com>,
Kyle Fazzari <git@status.e4ward.com>,
Mario Limonciello <mario_limonciello@dell.com>,
Tim Gardner <tim.gardner@canonical.com>,
Herton Krzesinski <herton.krzesinski@canonical.com>
Subject: Re: [PATCH v6] Cypress PS/2 Trackpad driver
Date: Mon, 10 Dec 2012 10:13:38 -0800 [thread overview]
Message-ID: <20121210181338.GA11233@core.coreip.homeip.net> (raw)
In-Reply-To: <20121210171359.GA881@polaris.bitmath.org>
On Mon, Dec 10, 2012 at 06:13:59PM +0100, Henrik Rydberg wrote:
> > > > +config MOUSE_PS2_CYPRESS
> > > > + bool "Cypress PS/2 mouse protocol extension" if EXPERT
> > >
> > > Why EXPERT here?
> > >
> > > > + default y
> > >
> > > Should it really be default y here?
> >
> >
> > This config entry (with phrases "if EXPERT" and "default y") was simply
> > cloned from similar devices (e.g. SYNAPTICS, ALPS, LIFEBOOK).
> >
> > If your preference is that CYPRESS should be disabled by default, I'll
> > omit those phrases. Please advise.
>
> Dmitry, which default do you prefer here?
Given that psmouse is monolithic and can't be [easily] split into
separate drivers (because they each protocol has to be actively probed),
I believe that allprotocols should be enabled by default. People who
really know what they are doing can reduce the size by compiling parts
of it out.
So copying what other protocols did was right ;)
Thanks.
--
Dmitry
next prev parent reply other threads:[~2012-12-10 18:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-07 2:10 [PATCH v6] Cypress PS/2 Trackpad driver Kamal Mostafa
2012-12-08 12:54 ` Henrik Rydberg
2012-12-08 17:03 ` Kamal Mostafa
2012-12-10 17:13 ` Henrik Rydberg
2012-12-10 18:13 ` Dmitry Torokhov [this message]
2012-12-10 2:44 ` Dudley Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210181338.GA11233@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=dso@cypress.com \
--cc=dudl@cypress.com \
--cc=git@status.e4ward.com \
--cc=herton.krzesinski@canonical.com \
--cc=kamal@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario_limonciello@dell.com \
--cc=rydberg@euromail.se \
--cc=ta@cypress.com \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).