From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v6] Cypress PS/2 Trackpad driver Date: Mon, 10 Dec 2012 10:13:38 -0800 Message-ID: <20121210181338.GA11233@core.coreip.homeip.net> References: <1354846216-19707-1-git-send-email-kamal@canonical.com> <20121208125405.GA3183@polaris.bitmath.org> <1354986225.2795.107.camel@fourier> <20121210171359.GA881@polaris.bitmath.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20121210171359.GA881@polaris.bitmath.org> Sender: linux-kernel-owner@vger.kernel.org To: Henrik Rydberg Cc: Kamal Mostafa , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Dudley Du , David Solda , Troy Abercrombia , Kyle Fazzari , Mario Limonciello , Tim Gardner , Herton Krzesinski List-Id: linux-input@vger.kernel.org On Mon, Dec 10, 2012 at 06:13:59PM +0100, Henrik Rydberg wrote: > > > > +config MOUSE_PS2_CYPRESS > > > > + bool "Cypress PS/2 mouse protocol extension" if EXPERT > > > > > > Why EXPERT here? > > > > > > > + default y > > > > > > Should it really be default y here? > > > > > > This config entry (with phrases "if EXPERT" and "default y") was simply > > cloned from similar devices (e.g. SYNAPTICS, ALPS, LIFEBOOK). > > > > If your preference is that CYPRESS should be disabled by default, I'll > > omit those phrases. Please advise. > > Dmitry, which default do you prefer here? Given that psmouse is monolithic and can't be [easily] split into separate drivers (because they each protocol has to be actively probed), I believe that allprotocols should be enabled by default. People who really know what they are doing can reduce the size by compiling parts of it out. So copying what other protocols did was right ;) Thanks. -- Dmitry