From: Grant Likely <grant.likely@secretlab.ca>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Simon Glass <sjg@chromium.org>,
Luigi Semenzato <semenzato@chromium.org>,
Vincent Palatin <vpalatin@chromium.org>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Sourav Poddar <sourav.poddar@ti.com>, Felipe Balbi <balbi@ti.com>,
Olof Johansson <olof@lixom.net>, Roland Stigge <stigge@antcom.de>,
Wolfram Sang <w.sang@pengutronix.de>,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH 5/5] Input: Add ChromeOS EC keyboard driver
Date: Sat, 15 Dec 2012 01:13:45 +0000 [thread overview]
Message-ID: <20121215011345.9D5973E0BEE@localhost> (raw)
In-Reply-To: <1355348028-19017-6-git-send-email-sjg@chromium.org>
On Wed, 12 Dec 2012 13:33:48 -0800, Simon Glass <sjg@chromium.org> wrote:
> Use the key-matrix layer to interpret key scan information from the EC
> and inject input based on the FDT-supplied key map. This driver registers
> itself with the ChromeOS EC driver to perform communications.
>
> Additional FDT bindings are provided to specify rows/columns and the
> auto-repeat information.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Luigi Semenzato <semenzato@chromium.org>
> Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
> ---
> .../devicetree/bindings/input/cros-ec-keyb.txt | 77 ++++
> drivers/input/keyboard/Kconfig | 10 +
> drivers/input/keyboard/Makefile | 1 +
> drivers/input/keyboard/cros_ec_keyb.c | 413 ++++++++++++++++++++
> 4 files changed, 501 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/input/cros-ec-keyb.txt
> create mode 100644 drivers/input/keyboard/cros_ec_keyb.c
>
> diff --git a/Documentation/devicetree/bindings/input/cros-ec-keyb.txt b/Documentation/devicetree/bindings/input/cros-ec-keyb.txt
> new file mode 100644
> index 0000000..67f51d8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/cros-ec-keyb.txt
> @@ -0,0 +1,77 @@
> +ChromeOS EC Keyboard
> +
> +Google's ChromeOS EC Keyboard is a simple matrix keyboard implemented on
> +a separate EC (Embedded Controller) device. It provides a message for reading
> +key scans from the EC. These are then converted into keycodes for processing
> +by the kernel.
> +
> +Required properties:
> +- compatible: "google,cros-ec-keyb"
> +- google,key-rows: Number of keyboard rows (must be <= 8)
> +- google,key-columns: Number of keyboard columns (must be <= 13)
> +- google,repeat-delay-ms: Key repeat delay in milliseconds
> +- google,repeat-rate-ms: Key repeat rate in milliseconds
Hmmm, these should probably be in a common binding. Take a look at
the other input bindings and make a proposal for properties to add to
matrix-keymap.txt.
> +- linux.keymap: Key map as for matrix-keypad.txt
should be: linux,keymap (comma instead of period)
g.
next prev parent reply other threads:[~2012-12-15 1:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 21:33 [PATCH 0/5] Add ChromeOS Embedded Controller support Simon Glass
[not found] ` <1355348028-19017-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-12-12 21:33 ` [PATCH 5/5] Input: Add ChromeOS EC keyboard driver Simon Glass
2012-12-15 1:13 ` Grant Likely [this message]
2012-12-15 1:43 ` Dmitry Torokhov
2012-12-19 12:57 ` Grant Likely
2012-12-19 18:16 ` Dmitry Torokhov
[not found] ` <20121219181643.GA31435-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2012-12-19 20:20 ` Simon Glass
2012-12-19 20:42 ` Grant Likely
2013-01-11 1:51 ` Simon Glass
2012-12-19 20:35 ` Simon Glass
2013-02-13 0:37 ` [PATCH 0/5] Add ChromeOS Embedded Controller support Simon Glass
2013-02-13 1:40 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121215011345.9D5973E0BEE@localhost \
--to=grant.likely@secretlab.ca \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sameo@linux.intel.com \
--cc=semenzato@chromium.org \
--cc=sjg@chromium.org \
--cc=sourav.poddar@ti.com \
--cc=stigge@antcom.de \
--cc=vpalatin@chromium.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).