From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] input:stmpe-ts: Add support to report BTN_TOUCH event Date: Sun, 16 Dec 2012 23:11:45 -0800 Message-ID: <20121217071144.GA10898@core.coreip.homeip.net> References: <7c50ed5f531db8ab992ebeaf1a48853a6274faf2.1355376050.git.vipulkumar.samar@st.com> <20121213091004.GF27617@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pb0-f46.google.com ([209.85.160.46]:38552 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813Ab2LQHLt (ORCPT ); Mon, 17 Dec 2012 02:11:49 -0500 Received: by mail-pb0-f46.google.com with SMTP id wy7so3772782pbc.19 for ; Sun, 16 Dec 2012 23:11:49 -0800 (PST) Content-Disposition: inline In-Reply-To: <20121213091004.GF27617@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Lee Jones Cc: Vipul Kumar Samar , linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, spear-devel@list.st.com, viresh.kumar@linaro.org, shiraz.hashim@st.com On Thu, Dec 13, 2012 at 09:10:04AM +0000, Lee Jones wrote: > On Thu, 13 Dec 2012, Vipul Kumar Samar wrote: > > > stmpe touchscreen supports BTN_TOUCH event but doesn't report it. Add > > BTN_TOUCH reporting capability to the stmpe touchscreen driver. > > > > Signed-off-by: Vipul Kumar Samar > > --- > > drivers/input/touchscreen/stmpe-ts.c | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c > > index 076442a..c3399a1 100644 > > --- a/drivers/input/touchscreen/stmpe-ts.c > > +++ b/drivers/input/touchscreen/stmpe-ts.c > > @@ -121,6 +121,7 @@ static void stmpe_work(struct work_struct *work) > > __stmpe_reset_fifo(ts->stmpe); > > > > input_report_abs(ts->idev, ABS_PRESSURE, 0); > > + input_report_key(ts->idev, BTN_TOUCH, 0); > > input_sync(ts->idev); > > } > > > > @@ -154,6 +155,7 @@ static irqreturn_t stmpe_ts_handler(int irq, void *data) > > input_report_abs(ts->idev, ABS_X, x); > > input_report_abs(ts->idev, ABS_Y, y); > > input_report_abs(ts->idev, ABS_PRESSURE, z); > > + input_report_key(ts->idev, BTN_TOUCH, 1); > > input_sync(ts->idev); > > > > /* flush the FIFO after we have read out our values. */ > > -- > > 1.7.2.2 > > So long as it's tested/working, the code looks fine so: > > Acked-by: Lee Jones Applied, thank you. -- Dmitry