From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Simon Glass <sjg@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-input@vger.kernel.org, Rob Landley <rob@landley.net>,
Grant Likely <grant.likely@secretlab.ca>,
devicetree-discuss@lists.ozlabs.org,
Roland Stigge <stigge@antcom.de>,
linux-doc@vger.kernel.org,
Vincent Palatin <vpalatin@chromium.org>,
Wolfram Sang <w.sang@pengutronix.de>, Felipe Balbi <balbi@ti.com>,
Sourav Poddar <sourav.poddar@ti.com>,
Luigi Semenzato <semenzato@chromium.org>,
Olof Johansson <olof@lixom.net>,
Rob Herring <rob.herring@calxeda.com>,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH] RFC: input: Extend matrix-keypad device tree binding
Date: Thu, 20 Dec 2012 13:13:23 -0800 [thread overview]
Message-ID: <20121220211323.GA24981@core.coreip.homeip.net> (raw)
In-Reply-To: <1356035039-21653-1-git-send-email-sjg@chromium.org>
Hi Simon,
On Thu, Dec 20, 2012 at 12:23:58PM -0800, Simon Glass wrote:
>
> For the key repeat feature, we need to set this after the input device
> is registered. So we would need to add a matrix_keypad_setup_input() or
> similar to be called by the driver after input_register_device(). I am
> less keen on that idea, and less again on the alternative of perhaps
> matrix_keypad_register_device() which does input_register_device() and
> then sets up the key repeat. Thoughts?
No, we already have default rate and delay. Unless you can prove that
random firmware writer's idea of appropriate delay and rate is better
then current default - for everyone - and then can successfully argue
that that obviously best delay/rate combo should not replace the current
one but stay only in DT bindings, let's keep relying on users adjusting
their own preferences from respective desktop environments/console/etc.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2012-12-20 21:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 20:23 [PATCH] RFC: input: Extend matrix-keypad device tree binding Simon Glass
2012-12-20 21:03 ` Stephen Warren
2012-12-20 21:13 ` Dmitry Torokhov [this message]
2012-12-20 21:41 ` Simon Glass
2012-12-21 16:47 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121220211323.GA24981@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=semenzato@chromium.org \
--cc=sjg@chromium.org \
--cc=sourav.poddar@ti.com \
--cc=stigge@antcom.de \
--cc=swarren@nvidia.com \
--cc=vpalatin@chromium.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).