From: Lee Jones <lee.jones@linaro.org>
To: Marek Vasut <marex@denx.de>
Cc: linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Vipul Kumar Samar <vipulkumar.samar@st.com>,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH] mfd: stmpe: Pull IRQ GPIO number from DT during DT-based probe
Date: Mon, 7 Jan 2013 15:44:01 +0000 [thread overview]
Message-ID: <20130107154401.GW21994@gmail.com> (raw)
In-Reply-To: <201301071613.33573.marex@denx.de>
> > > + pdata->irq_over_gpio = of_get_property(np, "irq-over-gpio", NULL);
> >
> > This is a new DT binding and you haven't provided any documentation for it.
> >
> > Also, there is no reason for the binding to exist.
> >
> > Lots of drivers use GPIO pins as IRQs.
>
> Right, this can be removed and only the 'irq-gpios' can be kept around. What do
> you say?
I don't like it to be honest.
How many GPIOs does the STMPE driver need?
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-01-07 15:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 14:29 [PATCH] mfd: stmpe: Pull IRQ GPIO number from DT during DT-based probe Marek Vasut
2013-01-07 15:03 ` Lee Jones
2013-01-07 15:13 ` Marek Vasut
2013-01-07 15:44 ` Lee Jones [this message]
2013-01-07 18:19 ` Viresh Kumar
2013-01-08 3:52 ` vipul kumar samar
2013-01-08 9:41 ` Lee Jones
2013-01-08 9:44 ` Marek Vasut
2013-01-08 9:48 ` Marek Vasut
2013-01-08 10:47 ` Viresh Kumar
2013-01-08 11:11 ` Lee Jones
2013-01-08 11:14 ` Viresh Kumar
2013-01-08 11:18 ` Laxman Dewangan
2013-01-08 11:23 ` Viresh Kumar
2013-01-10 11:42 ` Linus Walleij
2013-01-10 12:57 ` Lee Jones
2013-02-08 22:51 ` Grant Likely
2013-02-14 16:26 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130107154401.GW21994@gmail.com \
--to=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=marex@denx.de \
--cc=sameo@linux.intel.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).