From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: s.hauer@pengutronix.de, linux-input@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] Input: touchscreen: mc13783_ts.c: Convert to platform driver
Date: Mon, 7 Jan 2013 12:59:28 -0800 [thread overview]
Message-ID: <20130107205928.GA22813@core.coreip.homeip.net> (raw)
In-Reply-To: <CAOMZO5AeOg20V6Feh1psXYNbhPeTeTq9d8kNusNtD_Lb8CHLyw@mail.gmail.com>
On Mon, Jan 07, 2013 at 06:55:48PM -0200, Fabio Estevam wrote:
> Hi Dmitry,
>
> On Mon, Jan 7, 2013 at 6:50 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
>
> > This is not equivalent transformation. Did you intend to change the
> > behavior? If you this should be mentioned (and reasoned) in the
> > patch description.
>
> Sorry, do not understand why the behavior changes? Can you please explain?
module_platform_driver() internally uses platform_driver_register()
whereas the original code used platform_driver_probe(). These 2 behave
differently.
--
Dmitry
next prev parent reply other threads:[~2013-01-07 20:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 20:32 [PATCH] Input: touchscreen: mc13783_ts.c: Convert to platform driver Fabio Estevam
2013-01-07 20:50 ` Dmitry Torokhov
2013-01-07 20:55 ` Fabio Estevam
2013-01-07 20:59 ` Dmitry Torokhov [this message]
2013-01-07 21:01 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130107205928.GA22813@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).