From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input: touchscreen: mc13783_ts.c: Convert to platform driver Date: Mon, 7 Jan 2013 12:59:28 -0800 Message-ID: <20130107205928.GA22813@core.coreip.homeip.net> References: <1357590777-7498-1-git-send-email-festevam@gmail.com> <20130107205010.GA24637@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f43.google.com ([209.85.220.43]:33973 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753717Ab3AGU7b (ORCPT ); Mon, 7 Jan 2013 15:59:31 -0500 Received: by mail-pa0-f43.google.com with SMTP id fb10so10991260pad.16 for ; Mon, 07 Jan 2013 12:59:31 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Fabio Estevam Cc: s.hauer@pengutronix.de, linux-input@vger.kernel.org, Fabio Estevam On Mon, Jan 07, 2013 at 06:55:48PM -0200, Fabio Estevam wrote: > Hi Dmitry, > > On Mon, Jan 7, 2013 at 6:50 PM, Dmitry Torokhov > wrote: > > > This is not equivalent transformation. Did you intend to change the > > behavior? If you this should be mentioned (and reasoned) in the > > patch description. > > Sorry, do not understand why the behavior changes? Can you please explain? module_platform_driver() internally uses platform_driver_register() whereas the original code used platform_driver_probe(). These 2 behave differently. -- Dmitry