From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-input@vger.kernel.org, patches@linaro.org
Subject: Re: [PATCH 1/1] Input: samsung-keypad: Remove input_unregister_device() call
Date: Wed, 9 Jan 2013 01:21:32 -0800 [thread overview]
Message-ID: <20130109092132.GB4369@core.coreip.homeip.net> (raw)
In-Reply-To: <1357713829-30273-1-git-send-email-sachin.kamat@linaro.org>
On Wed, Jan 09, 2013 at 12:13:49PM +0530, Sachin Kamat wrote:
> Since devm_input_allocate_device() is used, explicit unregistering
> of device is not required as it is handled by devres infrastructure.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/input/keyboard/samsung-keypad.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/samsung-keypad.c b/drivers/input/keyboard/samsung-keypad.c
> index 22e357b..fab8972 100644
> --- a/drivers/input/keyboard/samsung-keypad.c
> +++ b/drivers/input/keyboard/samsung-keypad.c
> @@ -501,8 +501,6 @@ static int samsung_keypad_remove(struct platform_device *pdev)
> device_init_wakeup(&pdev->dev, 0);
> platform_set_drvdata(pdev, NULL);
>
> - input_unregister_device(keypad->input_dev);
> -
> clk_unprepare(keypad->clk);
>
No, don't you see clk_unprepare() call? The device must be unregistered
before calling clk_unprepare() to keep proper order of operations.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2013-01-09 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 6:43 [PATCH 1/1] Input: samsung-keypad: Remove input_unregister_device() call Sachin Kamat
2013-01-09 9:21 ` Dmitry Torokhov [this message]
2013-01-09 9:24 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130109092132.GB4369@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).