From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 1/1] Input: samsung-keypad: Remove input_unregister_device() call Date: Wed, 9 Jan 2013 01:21:32 -0800 Message-ID: <20130109092132.GB4369@core.coreip.homeip.net> References: <1357713829-30273-1-git-send-email-sachin.kamat@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pb0-f54.google.com ([209.85.160.54]:44329 "EHLO mail-pb0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757420Ab3AIJVe (ORCPT ); Wed, 9 Jan 2013 04:21:34 -0500 Received: by mail-pb0-f54.google.com with SMTP id wz12so823842pbc.13 for ; Wed, 09 Jan 2013 01:21:34 -0800 (PST) Content-Disposition: inline In-Reply-To: <1357713829-30273-1-git-send-email-sachin.kamat@linaro.org> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Sachin Kamat Cc: linux-input@vger.kernel.org, patches@linaro.org On Wed, Jan 09, 2013 at 12:13:49PM +0530, Sachin Kamat wrote: > Since devm_input_allocate_device() is used, explicit unregistering > of device is not required as it is handled by devres infrastructure. > > Signed-off-by: Sachin Kamat > --- > drivers/input/keyboard/samsung-keypad.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/keyboard/samsung-keypad.c b/drivers/input/keyboard/samsung-keypad.c > index 22e357b..fab8972 100644 > --- a/drivers/input/keyboard/samsung-keypad.c > +++ b/drivers/input/keyboard/samsung-keypad.c > @@ -501,8 +501,6 @@ static int samsung_keypad_remove(struct platform_device *pdev) > device_init_wakeup(&pdev->dev, 0); > platform_set_drvdata(pdev, NULL); > > - input_unregister_device(keypad->input_dev); > - > clk_unprepare(keypad->clk); > No, don't you see clk_unprepare() call? The device must be unregistered before calling clk_unprepare() to keep proper order of operations. Thanks. -- Dmitry