From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [PATCH] goldfish: virtual input event driver Date: Thu, 24 Jan 2013 17:16:42 +0000 Message-ID: <20130124171642.387d7e40@bob.linux.org.uk> References: <20130123173840.996.9588.stgit@bob.linux.org.uk> <20130124041547.GB7112@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mga14.intel.com ([143.182.124.37]:3315 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752143Ab3AXQ4X (ORCPT ); Thu, 24 Jan 2013 11:56:23 -0500 In-Reply-To: <20130124041547.GB7112@core.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: linux-input@vger.kernel.org On Wed, 23 Jan 2013 20:15:47 -0800 Dmitry Torokhov wrote: > Hi Alan, > > On Wed, Jan 23, 2013 at 05:38:43PM +0000, Alan Cox wrote: > > From: Brian Swetland > > > > This device is a direct pipe from "hardware" to the input > > event subsystem, allowing us to avoid having to route > > "keypad" style events through an AT keyboard driver (gross!) > > > > As with the other submissions this driver is cross architecture. > > > > Signed-off-by: Mike A. Chan > > [Tided up to work on x86] > > Signed-off-by: Sheng Yang > > Signed-off-by: Yunhong Jiang > > Signed-off-by: Xiaohui Xin > > Signed-off-by: Jun Nakajima > > Signed-off-by: Bruce Beare > > [Ported to 3.4] > > Signed-off-by: Tom Keel > > [Cleaned up for 3.7 and submission] > > Signed-off-by: Alan Cox > > I do not have drivers/tty/goldfish.c so I dropped that change... I > also had a few more cleanups, the result is below. Looks good to me - I wasn't sure about the remove method so I copied the other keyboard drivers that still had one even though they used devm_ methods for the allocation. Alan