Linux Input/HID development
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: matrix-keypad - support binary column select gpios
Date: Wed, 30 Jan 2013 09:44:32 +0100	[thread overview]
Message-ID: <20130130094432.17cf30fd@crub> (raw)
In-Reply-To: <20130130011628.GD5446@core.coreip.homeip.net>

Hi Dmitry,

On Tue, 29 Jan 2013 17:16:29 -0800
Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
...
> On Tue, Jan 29, 2013 at 01:25:24PM +0100, Anatolij Gustschin wrote:
> > On hardware with limited gpios one column select gpio can select
> > two different rows when using some additional hardware logic:
> > high value selects one row, low value selects another row. Add
> > support for such matrix keyboards and document device tree
> > bindings used to describe them.
> > 
> > Since half of the columns is always not selected, interrupts won't be
> > generated for press events on these columns. To generate interrupts
> > for not selected columns we need to periodicaly switch to these columns
> > in order to catch the potential press events. This is done by additional
> > work function.
> 
> So this effectively switches the driver from interrupt driven to polled
> model, right? The device does not really need an interrupt anymore...

Yes, partially. I do not need to scan the state of the rows right
after column switching. The interrupts for press events will only be
generated if a key in the affected row was actually pressed. So the
device is still interrupt driven and the row state read-out happens
in the work scheduled from the interrupt handler.

Thanks,

Anatolij

  reply	other threads:[~2013-01-30  8:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-29 12:25 [PATCH] Input: matrix-keypad - support binary column select gpios Anatolij Gustschin
2013-01-30  1:16 ` Dmitry Torokhov
2013-01-30  8:44   ` Anatolij Gustschin [this message]
2013-02-20 19:27 ` [PATCH v2] " Anatolij Gustschin
2013-02-20 21:09   ` Stephen Warren
2013-02-21  7:41   ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130130094432.17cf30fd@crub \
    --to=agust@denx.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox