From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH v2] input: Extend matrix-keypad device tree binding Date: Fri, 08 Feb 2013 12:59:24 +0000 Message-ID: <20130208125924.65E803E2B73@localhost> References: <1357868492-16023-1-git-send-email-sjg@chromium.org> <50F0473F.404@wwwdotorg.org> Return-path: Received: from mail-we0-f182.google.com ([74.125.82.182]:65024 "EHLO mail-we0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946545Ab3BHM7a (ORCPT ); Fri, 8 Feb 2013 07:59:30 -0500 Received: by mail-we0-f182.google.com with SMTP id t57so3057583wey.27 for ; Fri, 08 Feb 2013 04:59:29 -0800 (PST) In-Reply-To: <50F0473F.404@wwwdotorg.org> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Stephen Warren , Simon Glass Cc: Roland Stigge , Vincent Palatin , linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Dmitry Torokhov , LKML , Felipe Balbi , Wolfram Sang , Luigi Semenzato , Laxman Dewangan , Rob Herring , linux-input@vger.kernel.org, Stephen Warren , Sourav Poddar , Alban Bedel On Fri, 11 Jan 2013 10:09:19 -0700, Stephen Warren wrote: > On 01/10/2013 06:41 PM, Simon Glass wrote: > > Some matrix keypad drivers can support different numbers of rows and > > columns. Add a generic binding for these. > > > > Implementation note: > > > > In order to implement this binding in the kernel, we will need to modify > > matrix_keypad_() to look up the number of rows and cols in > > the keymap. Perhaps this could be done by passing 0 for these parameters? > > Many of the parameters can already be set to NULL. Ick. > > Reviewed-by: Stephen Warren Applied, thanks. g.