[PATCH 0/2] Input misc/bma150.[ch] one fix and one improvement

[PATCH 0/2] Input misc/bma150.[ch] one fix and one improvement

[Antonio Ospite]

From: Antonio Ospite <ao2@amarulasolutions.com>

Hi,

Patch 1 in the series fixes a panic Michael was experiencing.

Patch 2 makes it easier to use the actual values the implementation
expects in the platform data.

Regards,
   Antonio

Michael Trimarchi (2):
  Input: misc/bma150.c, fix checking pm_runtime_get_sync() return value
  Input: misc/bma150.[ch], make some defines public and fix some
    comments

 drivers/input/misc/bma150.c |   14 +-------------
 include/linux/bma150.h      |   16 ++++++++++++++--
 2 files changed, 15 insertions(+), 15 deletions(-)

-- 
Antonio Ospite
http://ao2.it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[PATCH 1/2] Input: misc/bma150.c, fix checking pm_runtime_get_sync() return value

[Antonio Ospite]

From: Michael Trimarchi <michael@amarulasolutions.com>

When PM_RUNTIME is not defined, pm_runtime_get_sync() returns 1, see
include/linux/pm_runtime.c::__pm_runtime_resume(), and the check of the
return value was overlooking this, in this case bma150_open() would
return 1 which is not expected by upper layers.

Maybe the check for != -ENOSYS (Function not implemented) was meant to
cover this, but pm_runtime_get_sync() does not return this value.

For now fix the issue locally by checking explicitly for negative return
values.

Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Antonio Ospite <ao2@amarulasolutions.com>
---
 drivers/input/misc/bma150.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/misc/bma150.c b/drivers/input/misc/bma150.c
index 08ffcab..e5d1894 100644
--- a/drivers/input/misc/bma150.c
+++ b/drivers/input/misc/bma150.c
@@ -372,7 +372,7 @@ static int bma150_open(struct bma150_data *bma150)
 	int error;
 
 	error = pm_runtime_get_sync(&bma150->client->dev);
-	if (error && error != -ENOSYS)
+	if (error < 0 && error != -ENOSYS)
 		return error;
 
 	/*
-- 
1.7.10.4

[PATCH 2/2] Input: misc/bma150.[ch], make some defines public and fix some comments

[Antonio Ospite]

From: Michael Trimarchi <michael@amarulasolutions.com>

Make the constants referring to range and bandwidth public so they can
be used when initializing the platform data fields in the platform code.

Fix also some comments regarding the unit of measurement to use for the
range and bandwidth fields, the values are not actually expected to be
in G or HZ, the code in bma150.c just uses the BMA150_RANGE_xxx and
BMA150_BW_xxx constants like they are with no translation from actual
values in G or HZ.

Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Antonio Ospite <ao2@amarulasolutions.com>
---
 drivers/input/misc/bma150.c |   12 ------------
 include/linux/bma150.h      |   16 ++++++++++++++--
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/drivers/input/misc/bma150.c b/drivers/input/misc/bma150.c
index e5d1894..865c2f9 100644
--- a/drivers/input/misc/bma150.c
+++ b/drivers/input/misc/bma150.c
@@ -46,18 +46,6 @@
 #define BMA150_POLL_MAX		200
 #define BMA150_POLL_MIN		0
 
-#define BMA150_BW_25HZ		0
-#define BMA150_BW_50HZ		1
-#define BMA150_BW_100HZ		2
-#define BMA150_BW_190HZ		3
-#define BMA150_BW_375HZ		4
-#define BMA150_BW_750HZ		5
-#define BMA150_BW_1500HZ	6
-
-#define BMA150_RANGE_2G		0
-#define BMA150_RANGE_4G		1
-#define BMA150_RANGE_8G		2
-
 #define BMA150_MODE_NORMAL	0
 #define BMA150_MODE_SLEEP	2
 #define BMA150_MODE_WAKE_UP	3
diff --git a/include/linux/bma150.h b/include/linux/bma150.h
index 7911fda..97ade7c 100644
--- a/include/linux/bma150.h
+++ b/include/linux/bma150.h
@@ -22,6 +22,18 @@
 
 #define BMA150_DRIVER		"bma150"
 
+#define BMA150_RANGE_2G		0
+#define BMA150_RANGE_4G		1
+#define BMA150_RANGE_8G		2
+
+#define BMA150_BW_25HZ		0
+#define BMA150_BW_50HZ		1
+#define BMA150_BW_100HZ		2
+#define BMA150_BW_190HZ		3
+#define BMA150_BW_375HZ		4
+#define BMA150_BW_750HZ		5
+#define BMA150_BW_1500HZ	6
+
 struct bma150_cfg {
 	bool any_motion_int;		/* Set to enable any-motion interrupt */
 	bool hg_int;			/* Set to enable high-G interrupt */
@@ -34,8 +46,8 @@ struct bma150_cfg {
 	unsigned char lg_hyst;		/* Low-G hysterisis */
 	unsigned char lg_dur;		/* Low-G duration */
 	unsigned char lg_thres;		/* Low-G threshold */
-	unsigned char range;		/* BMA0150_RANGE_xxx (in G) */
-	unsigned char bandwidth;	/* BMA0150_BW_xxx (in Hz) */
+	unsigned char range;		/* one of BMA0150_RANGE_xxx */
+	unsigned char bandwidth;	/* one of BMA0150_BW_xxx */
 };
 
 struct bma150_platform_data {
-- 
1.7.10.4

Re: [PATCH 0/2] Input misc/bma150.[ch] one fix and one improvement

[Antonio Ospite]

On Fri,  8 Feb 2013 00:58:23 +0100
Antonio Ospite <ospite@studenti.unina.it> wrote:

> From: Antonio Ospite <ao2@amarulasolutions.com>
> 
> Hi,
> 
> Patch 1 in the series fixes a panic Michael was experiencing.
> 
> Patch 2 makes it easier to use the actual values the implementation
> expects in the platform data.
>

Ping on this series, I forgot to Cc Dmitry in the original submission.
Dmitry, should I resend?

> Regards,
>    Antonio
> 
> Michael Trimarchi (2):
>   Input: misc/bma150.c, fix checking pm_runtime_get_sync() return value
>   Input: misc/bma150.[ch], make some defines public and fix some
>     comments
> 
>  drivers/input/misc/bma150.c |   14 +-------------
>  include/linux/bma150.h      |   16 ++++++++++++++--
>  2 files changed, 15 insertions(+), 15 deletions(-)
> 

-- 
Antonio Ospite
http://ao2.it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

Re: [PATCH 0/2] Input misc/bma150.[ch] one fix and one improvement

[Dmitry Torokhov]

On Fri, Feb 15, 2013 at 12:09:11PM +0100, Antonio Ospite wrote:
> On Fri,  8 Feb 2013 00:58:23 +0100
> Antonio Ospite <ospite@studenti.unina.it> wrote:
> 
> > From: Antonio Ospite <ao2@amarulasolutions.com>
> > 
> > Hi,
> > 
> > Patch 1 in the series fixes a panic Michael was experiencing.
> > 
> > Patch 2 makes it easier to use the actual values the implementation
> > expects in the platform data.
> >
> 
> Ping on this series, I forgot to Cc Dmitry in the original submission.
> Dmitry, should I resend?

No, I have them.

Thanks,

-- 
Dmitry