From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Simon Glass <sjg@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Luigi Semenzato <semenzato@chromium.org>,
Vincent Palatin <vpalatin@chromium.org>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>,
Sourav Poddar <sourav.poddar@ti.com>, Felipe Balbi <balbi@ti.com>,
Tony Lindgren <tony@atomide.com>,
Roland Stigge <stigge@antcom.de>,
Wolfram Sang <w.sang@pengutronix.de>,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH v5 6/6] Input: Add ChromeOS EC keyboard driver
Date: Wed, 20 Feb 2013 10:21:35 -0800 [thread overview]
Message-ID: <20130220182135.GC15152@core.coreip.homeip.net> (raw)
In-Reply-To: <1361381079-26747-7-git-send-email-sjg@chromium.org>
On Wed, Feb 20, 2013 at 09:24:39AM -0800, Simon Glass wrote:
> +
> + code = keycodes[pos];
> + new_state = kb_state[col] & (1 << row);
> + if (!!new_state != test_bit(code, idev->key)) {
> + dev_dbg(ckdev->dev,
> + "changed: [r%d c%d]: byte %02x\n",
> + row, col, new_state);
> +
> + input_report_key(idev, code, new_state);
Incorrect indentation.
> + }
...
> +static int cros_ec_keyb_probe(struct platform_device *pdev)
> +{
> + struct cros_ec_device *ec = dev_get_drvdata(pdev->dev.parent);
> + struct device *dev = ec->dev;
> + struct cros_ec_keyb *ckdev = NULL;
> + struct input_dev *idev = NULL;
Why are we assigning these to NULL?
Otherwise
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
--
Dmitry
prev parent reply other threads:[~2013-02-20 18:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 17:24 [PATCH v5 0/6] Add ChromeOS Embedded Controller support Simon Glass
2013-02-20 17:24 ` [PATCH v5 5/6] Input: matrix-keymap: Add function to read the new DT binding Simon Glass
2013-02-20 18:18 ` Dmitry Torokhov
2013-02-25 21:53 ` Simon Glass
[not found] ` <1361381079-26747-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2013-02-20 17:24 ` [PATCH v5 6/6] Input: Add ChromeOS EC keyboard driver Simon Glass
2013-02-20 18:21 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130220182135.GC15152@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sameo@linux.intel.com \
--cc=semenzato@chromium.org \
--cc=sjg@chromium.org \
--cc=sourav.poddar@ti.com \
--cc=stigge@antcom.de \
--cc=tony@atomide.com \
--cc=vpalatin@chromium.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).