From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Rabin Vincent <rabin.vincent@stericsson.com>
Cc: linux-input@vger.kernel.org, rabin@rab.in
Subject: Re: [PATCH] Input: tc3589x-keypad - fix keymap size
Date: Sat, 9 Mar 2013 16:23:00 -0800 [thread overview]
Message-ID: <20130310002300.GA31236@core.coreip.homeip.net> (raw)
In-Reply-To: <1362752803-21853-1-git-send-email-rabin.vincent@stericsson.com>
On Fri, Mar 08, 2013 at 03:26:43PM +0100, Rabin Vincent wrote:
> The keymap size used by tc3589x is too low, leading to the driver
> overwriting other people's memory. Fix this by making the driver use
> the automatically allocated keymap provided by
> matrix_keypad_build_keymap() instead of allocating one on its own.
>
> Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com>
Applied, thank you Rabin.
Do you think you could prepare a patch against stable as older kernels
should have the same issue but matrix_keypad_build_keymap does not
allocate keymap there?
Thanks!
--
Dmitry
next prev parent reply other threads:[~2013-03-10 0:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 14:26 [PATCH] Input: tc3589x-keypad - fix keymap size Rabin Vincent
2013-03-10 0:23 ` Dmitry Torokhov [this message]
2013-03-11 15:54 ` Rabin Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130310002300.GA31236@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=rabin.vincent@stericsson.com \
--cc=rabin@rab.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).