From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: s.hauer@pengutronix.de, linux-input@vger.kernel.org,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] Input: imx_keypad - use devm_ functions
Date: Wed, 13 Mar 2013 09:38:45 -0700 [thread overview]
Message-ID: <20130313163845.GD27269@core.coreip.homeip.net> (raw)
In-Reply-To: <1363148484-5920-1-git-send-email-festevam@gmail.com>
Hi Fabio,
On Wed, Mar 13, 2013 at 01:21:24AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> @@ -572,15 +546,6 @@ static int imx_keypad_remove(struct platform_device *pdev)
>
> input_unregister_device(keypad->input_dev);
>
With managed input devices input_unregister_device() is not needed
either, please try removing imx_keypad_remove() altogether.
Thanks.
> - free_irq(keypad->irq, keypad);
> - clk_put(keypad->clk);
> -
> - iounmap(keypad->mmio_base);
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - release_mem_region(res->start, resource_size(res));
> -
> - kfree(keypad);
> -
> return 0;
> }
>
> --
> 1.7.9.5
>
--
Dmitry
prev parent reply other threads:[~2013-03-13 16:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 4:21 [PATCH] Input: imx_keypad - use devm_ functions Fabio Estevam
2013-03-13 16:38 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130313163845.GD27269@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox