From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 2/2] Input: eeti_ts - Remove redundant null check
Date: Sun, 31 Mar 2013 00:26:03 -0700 [thread overview]
Message-ID: <20130331072603.GB7919@core.coreip.homeip.net> (raw)
In-Reply-To: <1364457222-4381-2-git-send-email-sachin.kamat@linaro.org>
On Thu, Mar 28, 2013 at 01:23:42PM +0530, Sachin Kamat wrote:
> 'pdata' is already dereferenced earlier. Hence this check is
> meaningless.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/input/touchscreen/eeti_ts.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/eeti_ts.c b/drivers/input/touchscreen/eeti_ts.c
> index 55255a9..8fe5086 100644
> --- a/drivers/input/touchscreen/eeti_ts.c
> +++ b/drivers/input/touchscreen/eeti_ts.c
> @@ -206,8 +206,7 @@ static int eeti_ts_probe(struct i2c_client *client,
> if (err < 0)
> goto err1;
>
> - if (pdata)
> - priv->irq_active_high = pdata->irq_active_high;
> + priv->irq_active_high = pdata->irq_active_high;
>
> irq_flags = priv->irq_active_high ?
> IRQF_TRIGGER_RISING : IRQF_TRIGGER_FALLING;
> --
> 1.7.4.1
>
Applied both, thank you Sachin.
--
Dmitry
prev parent reply other threads:[~2013-03-31 7:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 7:53 [PATCH 1/2] Input: edt-ft5x06 - Remove redundant null check before kfree Sachin Kamat
2013-03-28 7:53 ` [PATCH 2/2] Input: eeti_ts - Remove redundant null check Sachin Kamat
2013-03-31 7:26 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130331072603.GB7919@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).