From: Hans-Christian Egtvedt <egtvedt@samfundet.no>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 2/9] Input: atmel-wm97xx - Remove redundant platform_set_drvdata()
Date: Fri, 3 May 2013 13:25:51 +0200 [thread overview]
Message-ID: <20130503112551.GA17780@samfundet.no> (raw)
In-Reply-To: <1367576922-31459-2-git-send-email-sachin.kamat@linaro.org>
Around Fri 03 May 2013 15:58:35 +0530 or thereabout, Sachin Kamat wrote:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> Cc: Mark Brown <broonie@kernel.org>
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> ---
> drivers/input/touchscreen/atmel-wm97xx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/atmel-wm97xx.c b/drivers/input/touchscreen/atmel-wm97xx.c
> index 2c1e46b..268a35e 100644
> --- a/drivers/input/touchscreen/atmel-wm97xx.c
> +++ b/drivers/input/touchscreen/atmel-wm97xx.c
> @@ -372,7 +372,6 @@ static int __init atmel_wm97xx_probe(struct platform_device *pdev)
> err_irq:
> free_irq(atmel_wm97xx->ac97c_irq, atmel_wm97xx);
> err:
> - platform_set_drvdata(pdev, NULL);
> kfree(atmel_wm97xx);
> return ret;
> }
> @@ -386,7 +385,6 @@ static int __exit atmel_wm97xx_remove(struct platform_device *pdev)
> free_irq(atmel_wm97xx->ac97c_irq, atmel_wm97xx);
> del_timer_sync(&atmel_wm97xx->pen_timer);
> wm97xx_unregister_mach_ops(wm);
> - platform_set_drvdata(pdev, NULL);
> kfree(atmel_wm97xx);
>
> return 0;
--
mvh
Hans-Christian Egtvedt
next prev parent reply other threads:[~2013-05-03 11:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 10:28 [PATCH 1/9] Input: 88pm860x-ts- Remove redundant platform_set_drvdata() Sachin Kamat
2013-05-03 10:28 ` [PATCH 2/9] Input: atmel-wm97xx - " Sachin Kamat
2013-05-03 11:25 ` Hans-Christian Egtvedt [this message]
2013-05-03 10:28 ` [PATCH 3/9] Input: da9052_tsi " Sachin Kamat
2013-05-03 10:28 ` [PATCH 4/9] Input: intel-mid-touch: " Sachin Kamat
2013-05-03 10:28 ` [PATCH 5/9] Input: jornada720_ts - " Sachin Kamat
2013-05-03 10:28 ` [PATCH 6/9] Input: mc13783_ts: " Sachin Kamat
2013-05-03 10:28 ` [PATCH 7/9] Input: ti_am335x_tsc: " Sachin Kamat
2013-05-03 10:28 ` [PATCH 8/9] Input: tnetv107x-ts - " Sachin Kamat
2013-05-03 10:28 ` [PATCH 9/9] Input: w90p910_ts: " Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130503112551.GA17780@samfundet.no \
--to=egtvedt@samfundet.no \
--cc=broonie@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).