From: Hans-Christian Egtvedt <egtvedt@samfundet.no>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH 3/3] Input: gpio_mouse - Remove redundant platform_set_drvdata()
Date: Fri, 3 May 2013 13:27:13 +0200 [thread overview]
Message-ID: <20130503112713.GC17780@samfundet.no> (raw)
In-Reply-To: <1367577742-14712-3-git-send-email-sachin.kamat@linaro.org>
Around Fri 03 May 2013 16:12:22 +0530 or thereabout, Sachin Kamat wrote:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> ---
> drivers/input/mouse/gpio_mouse.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/input/mouse/gpio_mouse.c b/drivers/input/mouse/gpio_mouse.c
> index 532eaca..6b44413 100644
> --- a/drivers/input/mouse/gpio_mouse.c
> +++ b/drivers/input/mouse/gpio_mouse.c
> @@ -138,7 +138,6 @@ static int gpio_mouse_probe(struct platform_device *pdev)
>
> out_free_polldev:
> input_free_polled_device(input_poll);
> - platform_set_drvdata(pdev, NULL);
>
> out_free_gpios:
> while (--i >= 0) {
> @@ -165,8 +164,6 @@ static int gpio_mouse_remove(struct platform_device *pdev)
> gpio_free(pin);
> }
>
> - platform_set_drvdata(pdev, NULL);
> -
> return 0;
> }
>
--
mvh
Hans-Christian Egtvedt
prev parent reply other threads:[~2013-05-03 11:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 10:42 [PATCH 1/3] Input: q40kbd - Remove redundant platform_set_drvdata() Sachin Kamat
2013-05-03 10:42 ` [PATCH 2/3] Input: amimouse " Sachin Kamat
2013-05-03 10:42 ` [PATCH 3/3] Input: gpio_mouse " Sachin Kamat
2013-05-03 11:27 ` Hans-Christian Egtvedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130503112713.GC17780@samfundet.no \
--to=egtvedt@samfundet.no \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).