From: Marek Vasut <marex@denx.de>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH 09/20] Input: matrix_keypad - Remove redundant platform_set_drvdata()
Date: Mon, 6 May 2013 14:08:01 +0200 [thread overview]
Message-ID: <201305061408.01553.marex@denx.de> (raw)
In-Reply-To: <1367814240-8959-9-git-send-email-sachin.kamat@linaro.org>
Dear Sachin Kamat,
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Marek Vasut <marek.vasut@gmail.com>
It does make sense.
btw. if you're up to cleaning this up, you can also introduce some
devm_input_device_allocate() and switch kzalloc() to devm_kzalloc etc.
> ---
> drivers/input/keyboard/matrix_keypad.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/matrix_keypad.c
> b/drivers/input/keyboard/matrix_keypad.c index 71d7719..90ff73a 100644
> --- a/drivers/input/keyboard/matrix_keypad.c
> +++ b/drivers/input/keyboard/matrix_keypad.c
> @@ -549,8 +549,6 @@ static int matrix_keypad_remove(struct platform_device
> *pdev) input_unregister_device(keypad->input_dev);
> kfree(keypad);
>
> - platform_set_drvdata(pdev, NULL);
> -
> return 0;
> }
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-05-06 12:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 4:23 [PATCH 01/20] Input: amikbd - Remove redundant platform_set_drvdata() Sachin Kamat
2013-05-06 4:23 ` [PATCH 02/20] Input: bf54x-keys " Sachin Kamat
2013-05-06 4:23 ` [PATCH 03/20] Input: davinci_keyscan " Sachin Kamat
2013-05-06 4:23 ` [PATCH 04/20] Input: ep93xx_keypad " Sachin Kamat
2013-05-06 16:45 ` H Hartley Sweeten
2013-05-06 4:23 ` [PATCH 05/20] Input: gpio_keys " Sachin Kamat
2013-05-06 4:23 ` [PATCH 06/20] Input: gpio_keys_polled " Sachin Kamat
2013-05-06 4:23 ` [PATCH 07/20] Input: jornada680_kbd " Sachin Kamat
2013-05-06 4:23 ` [PATCH 08/20] Input: jornada720_kbd " Sachin Kamat
2013-05-06 4:23 ` [PATCH 09/20] Input: matrix_keypad " Sachin Kamat
2013-05-06 12:08 ` Marek Vasut [this message]
2013-05-06 4:23 ` [PATCH 10/20] Input: omap4-keypad " Sachin Kamat
2013-05-06 4:23 ` [PATCH 11/20] Input: opencores-kbd " Sachin Kamat
2013-05-06 4:23 ` [PATCH 12/20] Input: pmic8xxx-keypad " Sachin Kamat
2013-05-06 4:23 ` [PATCH 13/20] Input: pxa27x_keypad " Sachin Kamat
2013-05-06 4:23 ` [PATCH 14/20] Input: pxa930_rotary " Sachin Kamat
2013-05-06 4:23 ` [PATCH 15/20] Input: samsung-keypad " Sachin Kamat
2013-05-06 4:23 ` [PATCH 16/20] Input: sh_keysc " Sachin Kamat
2013-05-06 4:23 ` [PATCH 17/20] Input: spear-keyboard " Sachin Kamat
2013-05-13 4:04 ` Viresh Kumar
2013-05-06 4:23 ` [PATCH 18/20] Input: tnetv107x-keypad " Sachin Kamat
2013-05-06 4:23 ` [PATCH 19/20] Input: twl4030_keypad " Sachin Kamat
2013-05-06 4:24 ` [PATCH 20/20] Input: w90p910_keypad " Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305061408.01553.marex@denx.de \
--to=marex@denx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).