* [PATCH] cyttsp: Fix swap of mfg_stat and mfg_cmd registers
@ 2013-06-04 21:19 Matthias Kaehlcke
2013-06-05 9:21 ` Javier Martinez Canillas
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Kaehlcke @ 2013-06-04 21:19 UTC (permalink / raw)
To: Javier Martinez Canillas, Dmitry Torokhov
Cc: Kevin McNeely, linux-input, linux-kernel
The command and status register in the driver were swapped with
respect to the order specified in the datasheet (CY8CTMA140).
Confirmed with Cypress that the order in the datasheet is correct.
Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>
---
drivers/input/touchscreen/cyttsp_core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/cyttsp_core.h b/drivers/input/touchscreen/cyttsp_core.h
index 1aa3c69..f1ebde3 100644
--- a/drivers/input/touchscreen/cyttsp_core.h
+++ b/drivers/input/touchscreen/cyttsp_core.h
@@ -67,8 +67,8 @@ struct cyttsp_xydata {
/* TTSP System Information interface definition */
struct cyttsp_sysinfo_data {
u8 hst_mode;
- u8 mfg_cmd;
u8 mfg_stat;
+ u8 mfg_cmd;
u8 cid[3];
u8 tt_undef1;
u8 uid[8];
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] cyttsp: Fix swap of mfg_stat and mfg_cmd registers
2013-06-04 21:19 [PATCH] cyttsp: Fix swap of mfg_stat and mfg_cmd registers Matthias Kaehlcke
@ 2013-06-05 9:21 ` Javier Martinez Canillas
2013-06-10 11:02 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Javier Martinez Canillas @ 2013-06-05 9:21 UTC (permalink / raw)
To: Matthias Kaehlcke, Javier Martinez Canillas, Dmitry Torokhov,
Kevin McNeely, linux-input, linux-kernel
On Tue, Jun 4, 2013 at 11:19 PM, Matthias Kaehlcke
<matthias.list@kaehlcke.net> wrote:
> The command and status register in the driver were swapped with
> respect to the order specified in the datasheet (CY8CTMA140).
> Confirmed with Cypress that the order in the datasheet is correct.
>
> Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>
> ---
Acked-by: Javier Martinez Canillas <javier@dowhile0.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cyttsp: Fix swap of mfg_stat and mfg_cmd registers
2013-06-05 9:21 ` Javier Martinez Canillas
@ 2013-06-10 11:02 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2013-06-10 11:02 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Matthias Kaehlcke, Dmitry Torokhov, Kevin McNeely, linux-input,
linux-kernel
On 06/05/2013 12:21 PM, Javier Martinez Canillas wrote:
> On Tue, Jun 4, 2013 at 11:19 PM, Matthias Kaehlcke
> <matthias.list@kaehlcke.net> wrote:
>> The command and status register in the driver were swapped with
>> respect to the order specified in the datasheet (CY8CTMA140).
>> Confirmed with Cypress that the order in the datasheet is correct.
>>
>> Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>
>> ---
>
> Acked-by: Javier Martinez Canillas <javier@dowhile0.org>
Acked-by: Ferruh Yigit <fery@cypress.com>
This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-10 11:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-04 21:19 [PATCH] cyttsp: Fix swap of mfg_stat and mfg_cmd registers Matthias Kaehlcke
2013-06-05 9:21 ` Javier Martinez Canillas
2013-06-10 11:02 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).