linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Vishwanathrao Badarkhe, Manish" <manishv.b@ti.com>
Cc: "devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"davinci-linux-open-source@linux.davincidsp.com"
	<davinci-linux-open-source@linux.davincidsp.com>,
	"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
	"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
	"rob@landley.net" <rob@landley.net>
Subject: Re: [PATCH V3 1/2] tps6507x-ts: Add DT support
Date: Mon, 10 Jun 2013 11:03:11 -0700	[thread overview]
Message-ID: <20130610180311.GA4649@core.coreip.homeip.net> (raw)
In-Reply-To: <A4887BF146CD57468F700B415D2F47015A0DFD@DBDE04.ent.ti.com>

Manish,

On Mon, Jun 10, 2013 at 10:23:16AM +0000, Vishwanathrao Badarkhe, Manish wrote:
> Hi Dmitry,
> 
> On Mon, Jun 10, 2013 at 11:34:42, Dmitry Torokhov wrote:
> > Hi Manish,
> > 
> > On Tue, May 21, 2013 at 02:24:17PM +0530, Vishwanathrao Badarkhe, Manish wrote:
> > 
> > > +	struct touchscreen_init_data *init_data = NULL;
> > > +	int err;
> > > +
> > > +	if (node)
> > > +		node = of_find_node_by_name(node, "tsc");
> > 
> > Why do you have to locate OF node manually instead of already having it attached to the device stucture?
> 
> As TPS6507x is mfd device containing two nodes, regulator and touchscreen.
> It is necessary to use "of_find_node_by_name" to find child "tsc" node of 
> TPS6507x MFD device.

I understand that TPS6507x is a MFD device, However, I still do not
understand why you do not attach OF data to the child platform device
representing touchscreen when you create it.

Thanks.

-- 
Dmitry

  reply	other threads:[~2013-06-10 18:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-21  8:54 [PATCH V3 0/2] Add DT support for tps6507x touchscreen Vishwanathrao Badarkhe, Manish
2013-05-21  8:54 ` [PATCH V3 1/2] tps6507x-ts: Add DT support Vishwanathrao Badarkhe, Manish
     [not found]   ` <1369126458-24872-2-git-send-email-manishv.b-l0cyMroinI0@public.gmane.org>
2013-06-10  6:04     ` Dmitry Torokhov
2013-06-10 10:23       ` Vishwanathrao Badarkhe, Manish
2013-06-10 18:03         ` Dmitry Torokhov [this message]
2013-06-12  6:53           ` Vishwanathrao Badarkhe, Manish
     [not found]             ` <A4887BF146CD57468F700B415D2F47015A1315-yXqyApvAXouIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2013-07-01 11:10               ` Manish Badarkhe
2013-07-29  6:17                 ` Manish Badarkhe
     [not found]                   ` <CAKDJKT500ewMEv-f-vZBkMELkFkNBXLrv0oS_qUivbq0T-Y6yA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-08-20  5:56                     ` Manish Badarkhe
2013-06-12 11:24   ` Grant Likely
2013-08-20  6:14   ` Prabhakar Lad
2013-08-20  6:55     ` Manish Badarkhe
2013-08-21 16:20       ` Dmitry Torokhov
2013-05-21  8:54 ` [PATCH V3 2/2] ARM: davinci: da850: add tps6507x touchscreen DT data Vishwanathrao Badarkhe, Manish
2013-05-31  6:04 ` [PATCH V3 0/2] Add DT support for tps6507x touchscreen Vishwanathrao Badarkhe, Manish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130610180311.GA4649@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manishv.b@ti.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).