From: Djalal Harouni <tixxdz@opendz.org>
To: Ferruh Yigit <fery@cypress.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
ttdrivers@cypress.com,
Javier Martinez Canillas <javier@dowhile0.org>,
Kees Cook <keescook@chromium.org>,
Greg KH <gregkh@linuxfoundation.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Input: cyttsp - fix memcpy size param
Date: Mon, 17 Jun 2013 22:38:59 +0100 [thread overview]
Message-ID: <20130617213858.GA2805@dztty> (raw)
In-Reply-To: <1368192769-24067-1-git-send-email-fery@cypress.com>
(Cc'ed Kees and Greg)
Hi Dmitry,
On Fri, May 10, 2013 at 04:32:48PM +0300, Ferruh Yigit wrote:
> memcpy param is wrong because of offset in bl_cmd, this may corrupt the
> stack which may cause a crash.
>
> Tested-by: Ferruh Yigit <fery@cypress.com> on TMA300-DVK
> Signed-off-by: Ferruh Yigit <fery@cypress.com>
> ---
> drivers/input/touchscreen/cyttsp_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/cyttsp_core.c b/drivers/input/touchscreen/cyttsp_core.c
> index 8e60437..97ba891 100644
> --- a/drivers/input/touchscreen/cyttsp_core.c
> +++ b/drivers/input/touchscreen/cyttsp_core.c
> @@ -133,7 +133,7 @@ static int cyttsp_exit_bl_mode(struct cyttsp *ts)
> memcpy(bl_cmd, bl_command, sizeof(bl_command));
> if (ts->pdata->bl_keys)
> memcpy(&bl_cmd[sizeof(bl_command) - CY_NUM_BL_KEYS],
> - ts->pdata->bl_keys, sizeof(bl_command));
> + ts->pdata->bl_keys, CY_NUM_BL_KEYS);
>
> error = ttsp_write_block_data(ts, CY_REG_BASE,
> sizeof(bl_cmd), bl_cmd);
> --
> 1.7.9.5
I was going to send a patch and found that it was just fixed in todays
next-20130617
Anyway, will this overflow fix go for the next -rc?
Thanks in advance Dmitry!
--
Djalal Harouni
http://opendz.org
next prev parent reply other threads:[~2013-06-17 21:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 13:32 [PATCH 1/2] Input: cyttsp - fix memcpy size param Ferruh Yigit
2013-05-10 13:32 ` [PATCH 2/2] Input: cyttsp - add missing handshake Ferruh Yigit
2013-05-10 14:01 ` Javier Martinez Canillas
2013-05-10 13:56 ` [PATCH 1/2] Input: cyttsp - fix memcpy size param Javier Martinez Canillas
2013-06-17 21:38 ` Djalal Harouni [this message]
2013-06-17 21:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617213858.GA2805@dztty \
--to=tixxdz@opendz.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fery@cypress.com \
--cc=gregkh@linuxfoundation.org \
--cc=javier@dowhile0.org \
--cc=keescook@chromium.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ttdrivers@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).