From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH 2/2] Bluetooth: hidp: remove wrong send_report at init Date: Fri, 12 Jul 2013 11:09:23 +0100 Message-ID: <20130712100923.GA2065@joana> References: <1373550090-30379-1-git-send-email-benjamin.tissoires@redhat.com> <1373550090-30379-3-git-send-email-benjamin.tissoires@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1373550090-30379-3-git-send-email-benjamin.tissoires-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-bluetooth-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Benjamin Tissoires Cc: Benjamin Tissoires , Marcel Holtmann , David Herrmann , Jiri Kosina , linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-input@vger.kernel.org Hi Benjamin, * Benjamin Tissoires [2013-07-11 15:41:30 +0200]: > The USB hid implementation does retrieve the reports during the start. > However, this implementation does not call the HID command GET_REPORT > (which would fetch the current status of each report), but use the > DATA command, which is an Output Report (so transmitting data from the > host to the device). > The Wiimote controller is already guarded against this problem in the > protocol, but it is not conformant to the specification to set all the > reports to 0 on start. > > Signed-off-by: Benjamin Tissoires > --- > net/bluetooth/hidp/core.c | 14 -------------- > 1 file changed, 14 deletions(-) Both patches have been applied to bluetooth-next. Thanks. Gustavo