From mboxrd@z Thu Jan 1 00:00:00 1970 From: rydberg@euromail.se Subject: Re: [PATCH 02/51] Input: atmel_mxt_ts - Improve T19 GPIO keys handling Date: Thu, 18 Jul 2013 19:11:31 +0200 Message-ID: <20130718171131.GA32381@polaris.bitmath.org> References: <1372337366-9286-1-git-send-email-nick.dyer@itdev.co.uk> <1372337366-9286-3-git-send-email-nick.dyer@itdev.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtprelay-b21.telenor.se ([195.54.99.212]:35976 "EHLO smtprelay-b21.telenor.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758890Ab3GRRKW (ORCPT ); Thu, 18 Jul 2013 13:10:22 -0400 Content-Disposition: inline In-Reply-To: <1372337366-9286-3-git-send-email-nick.dyer@itdev.co.uk> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Nick Dyer Cc: Dmitry Torokhov , Daniel Kurtz , Joonyoung Shim , Alan Bowens , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Meerwald , Benson Leung , Olof Johansson On Thu, Jun 27, 2013 at 01:48:37PM +0100, Nick Dyer wrote: > > * The mapping of the GPIO numbers into the T19 status byte varies between > different maXTouch chips. Some have up to 7 GPIOs. Allowing a keycode array > of up to 8 items is simpler and more generic. So replace #define with > configurable number of keys which also allows the removal of is_tp. > * Rename platform data parameters to include "t19" to prevent confusion with > T15 key array. > * Probe aborts early on when pdata is NULL, so no need to check. > * Move "int i" to beginning of function (mixed declarations and code) > * Use API calls rather than __set_bit() > * Remove unused dev variable. > > Signed-off-by: Nick Dyer > --- > drivers/input/touchscreen/atmel_mxt_ts.c | 44 ++++++++++++------------------ > drivers/platform/x86/chromeos_laptop.c | 17 ++++++++---- > include/linux/i2c/atmel_mxt_ts.h | 7 ++--- > 3 files changed, 30 insertions(+), 38 deletions(-) Reviewed-by: Henrik Rydberg Thanks, Henrik