From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andrey Moiseev <o2g.org.ru@gmail.com>
Cc: linux-input@vger.kernel.org, arnoques@gmail.com,
russianneuromancer@ya.ru, ike.pan@canonical.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] input: ideapad_slidebar: new input driver
Date: Wed, 7 Aug 2013 11:42:54 -0700 [thread overview]
Message-ID: <20130807184254.GA830@core.coreip.homeip.net> (raw)
In-Reply-To: <52022EAE.5040000@gmail.com>
Hi Andrey,
On Wed, Aug 07, 2013 at 03:25:34PM +0400, Andrey Moiseev wrote:
> +/* Keyboard handler */
> +static irq_handler_t kbd_irq_handler(int irq, void *dev_id,
> + struct pt_regs *regs)
> +{
> + /* Scancodes: e03b on move, bb on release */
> + int scancode = inb(0x60);
No, you should not just read KBC data without regard to what other
parts of kernel are doing (i8042 might be accessing it at the same time
because AUX IRQ was raised).
This driver has to be implemented as i8042 filter.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2013-08-07 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 11:25 [PATCH v2 1/1] input: ideapad_slidebar: new input driver Andrey Moiseev
2013-08-07 18:42 ` Dmitry Torokhov [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-08-07 11:44 Andrey Moiseev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130807184254.GA830@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=arnoques@gmail.com \
--cc=ike.pan@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o2g.org.ru@gmail.com \
--cc=russianneuromancer@ya.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).