From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v2 1/1] input: ideapad_slidebar: new input driver Date: Wed, 7 Aug 2013 11:42:54 -0700 Message-ID: <20130807184254.GA830@core.coreip.homeip.net> References: <52022EAE.5040000@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pb0-f53.google.com ([209.85.160.53]:34756 "EHLO mail-pb0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757129Ab3HGSm7 (ORCPT ); Wed, 7 Aug 2013 14:42:59 -0400 Content-Disposition: inline In-Reply-To: <52022EAE.5040000@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Andrey Moiseev Cc: linux-input@vger.kernel.org, arnoques@gmail.com, russianneuromancer@ya.ru, ike.pan@canonical.com, linux-kernel@vger.kernel.org Hi Andrey, On Wed, Aug 07, 2013 at 03:25:34PM +0400, Andrey Moiseev wrote: > +/* Keyboard handler */ > +static irq_handler_t kbd_irq_handler(int irq, void *dev_id, > + struct pt_regs *regs) > +{ > + /* Scancodes: e03b on move, bb on release */ > + int scancode = inb(0x60); No, you should not just read KBC data without regard to what other parts of kernel are doing (i8042 might be accessing it at the same time because AUX IRQ was raised). This driver has to be implemented as i8042 filter. Thanks. -- Dmitry