From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Pau Oliva Fora <pau@eslack.org>
Subject: Re: [PATCH 1/1] Input: htcpen - Fix incorrect placement of __initdata
Date: Wed, 14 Aug 2013 23:51:38 -0700 [thread overview]
Message-ID: <20130815065138.GA15374@core.coreip.homeip.net> (raw)
In-Reply-To: <CAK9yfHy-Q8W=0ujnnMmspsSJuwJeH-GMpOky+_GkPXf14mHK5w@mail.gmail.com>
Hi Sachin,
On Wed, Aug 14, 2013 at 11:55:22AM +0530, Sachin Kamat wrote:
> Hi Dmitry,
>
> On 7 August 2013 15:09, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> > __initdata should be placed between the variable name and equal
> > sign for the variable to be placed in the intended section.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > Cc: Pau Oliva Fora <pau@eslack.org>
> > ---
> > drivers/input/touchscreen/htcpen.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/touchscreen/htcpen.c b/drivers/input/touchscreen/htcpen.c
> > index 6c4fb84..6650085 100644
> > --- a/drivers/input/touchscreen/htcpen.c
> > +++ b/drivers/input/touchscreen/htcpen.c
> > @@ -221,7 +221,7 @@ static struct isa_driver htcpen_isa_driver = {
> > }
> > };
> >
> > -static struct dmi_system_id __initdata htcshift_dmi_table[] = {
> > +static struct dmi_system_id htcshift_dmi_table[] __initdata = {
> > {
> > .ident = "Shift",
> > .matches = {
> > --
> > 1.7.9.5
> >
>
> Thanks for applying my other patches. Looks like you missed this one though :)
Got it now, thanks.
--
Dmitry
prev parent reply other threads:[~2013-08-15 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 9:39 [PATCH 1/1] Input: htcpen - Fix incorrect placement of __initdata Sachin Kamat
2013-08-14 6:25 ` Sachin Kamat
2013-08-15 6:51 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130815065138.GA15374@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=pau@eslack.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).