* [PATCH 1/1] Input: htcpen - Fix incorrect placement of __initdata
@ 2013-08-07 9:39 Sachin Kamat
2013-08-14 6:25 ` Sachin Kamat
0 siblings, 1 reply; 3+ messages in thread
From: Sachin Kamat @ 2013-08-07 9:39 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, sachin.kamat, Pau Oliva Fora
__initdata should be placed between the variable name and equal
sign for the variable to be placed in the intended section.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Pau Oliva Fora <pau@eslack.org>
---
drivers/input/touchscreen/htcpen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/htcpen.c b/drivers/input/touchscreen/htcpen.c
index 6c4fb84..6650085 100644
--- a/drivers/input/touchscreen/htcpen.c
+++ b/drivers/input/touchscreen/htcpen.c
@@ -221,7 +221,7 @@ static struct isa_driver htcpen_isa_driver = {
}
};
-static struct dmi_system_id __initdata htcshift_dmi_table[] = {
+static struct dmi_system_id htcshift_dmi_table[] __initdata = {
{
.ident = "Shift",
.matches = {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] Input: htcpen - Fix incorrect placement of __initdata
2013-08-07 9:39 [PATCH 1/1] Input: htcpen - Fix incorrect placement of __initdata Sachin Kamat
@ 2013-08-14 6:25 ` Sachin Kamat
2013-08-15 6:51 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Sachin Kamat @ 2013-08-14 6:25 UTC (permalink / raw)
To: linux-input@vger.kernel.org; +Cc: Dmitry Torokhov, Sachin Kamat, Pau Oliva Fora
Hi Dmitry,
On 7 August 2013 15:09, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> __initdata should be placed between the variable name and equal
> sign for the variable to be placed in the intended section.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Pau Oliva Fora <pau@eslack.org>
> ---
> drivers/input/touchscreen/htcpen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/htcpen.c b/drivers/input/touchscreen/htcpen.c
> index 6c4fb84..6650085 100644
> --- a/drivers/input/touchscreen/htcpen.c
> +++ b/drivers/input/touchscreen/htcpen.c
> @@ -221,7 +221,7 @@ static struct isa_driver htcpen_isa_driver = {
> }
> };
>
> -static struct dmi_system_id __initdata htcshift_dmi_table[] = {
> +static struct dmi_system_id htcshift_dmi_table[] __initdata = {
> {
> .ident = "Shift",
> .matches = {
> --
> 1.7.9.5
>
Thanks for applying my other patches. Looks like you missed this one though :)
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] Input: htcpen - Fix incorrect placement of __initdata
2013-08-14 6:25 ` Sachin Kamat
@ 2013-08-15 6:51 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2013-08-15 6:51 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-input@vger.kernel.org, Pau Oliva Fora
Hi Sachin,
On Wed, Aug 14, 2013 at 11:55:22AM +0530, Sachin Kamat wrote:
> Hi Dmitry,
>
> On 7 August 2013 15:09, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> > __initdata should be placed between the variable name and equal
> > sign for the variable to be placed in the intended section.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > Cc: Pau Oliva Fora <pau@eslack.org>
> > ---
> > drivers/input/touchscreen/htcpen.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/touchscreen/htcpen.c b/drivers/input/touchscreen/htcpen.c
> > index 6c4fb84..6650085 100644
> > --- a/drivers/input/touchscreen/htcpen.c
> > +++ b/drivers/input/touchscreen/htcpen.c
> > @@ -221,7 +221,7 @@ static struct isa_driver htcpen_isa_driver = {
> > }
> > };
> >
> > -static struct dmi_system_id __initdata htcshift_dmi_table[] = {
> > +static struct dmi_system_id htcshift_dmi_table[] __initdata = {
> > {
> > .ident = "Shift",
> > .matches = {
> > --
> > 1.7.9.5
> >
>
> Thanks for applying my other patches. Looks like you missed this one though :)
Got it now, thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-15 6:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-07 9:39 [PATCH 1/1] Input: htcpen - Fix incorrect placement of __initdata Sachin Kamat
2013-08-14 6:25 ` Sachin Kamat
2013-08-15 6:51 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).