From: Alexander Shiyan <shc_work@mail.ru>
To: Michael Grzeschik <mgr@pengutronix.de>
Cc: linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH v3 RESEND 1/3] input: mc13783: Prepare driver to support MC13892 and OF
Date: Sat, 17 Aug 2013 10:53:05 +0400 [thread overview]
Message-ID: <20130817105305.5201c078d4f2cf52ffb172f8@mail.ru> (raw)
In-Reply-To: <20130817062012.GA26693@pengutronix.de>
On Sat, 17 Aug 2013 08:20:12 +0200
Michael Grzeschik <mgr@pengutronix.de> wrote:
> On Sat, Aug 17, 2013 at 09:46:20AM +0400, Alexander Shiyan wrote:
> > This patch is a preparation mc13xxx powerbutton driver to support
> > MC13892 and support the probe through the DT.
>
> As this patch already mention by itself, it's doing to much at once.
> And by looking at it, it realy does more than it tells here.
>
> Can you rework that into seperate readable tasks. In this patch you
> nearly rewrite the whole file. That runs the review impossible.
All changes in this patch are addicted to each other, can not be divided.
As an alternative, I can do all as a new driver.
Thanks.
--
Alexander Shiyan <shc_work@mail.ru>
next prev parent reply other threads:[~2013-08-17 6:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-17 5:46 [PATCH v3 RESEND 1/3] input: mc13783: Prepare driver to support MC13892 and OF Alexander Shiyan
2013-08-17 5:46 ` [PATCH v3 RESEND 2/3] input: mc13783: Add MC13892 support Alexander Shiyan
2013-08-17 6:20 ` [PATCH v3 RESEND 1/3] input: mc13783: Prepare driver to support MC13892 and OF Michael Grzeschik
2013-08-17 6:53 ` Alexander Shiyan [this message]
2013-08-17 9:23 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130817105305.5201c078d4f2cf52ffb172f8@mail.ru \
--to=shc_work@mail.ru \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=mgr@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).