From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Grzeschik Subject: Re: [PATCH] mc13xxx-ts: use zero as default value if no pdata was defined Date: Tue, 20 Aug 2013 11:34:32 +0200 Message-ID: <20130820093432.GC26693@pengutronix.de> References: <1376396070-24507-1-git-send-email-m.grzeschik@pengutronix.de> <20130820013433.GE13324@zurbaran> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20130820013433.GE13324@zurbaran> Sender: linux-kernel-owner@vger.kernel.org To: Samuel Ortiz Cc: Michael Grzeschik , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Dmitry Torokhov List-Id: linux-input@vger.kernel.org On Tue, Aug 20, 2013 at 03:34:33AM +0200, Samuel Ortiz wrote: > Hi Michael, > > On Tue, Aug 13, 2013 at 02:14:30PM +0200, Michael Grzeschik wrote: > > In case of devicetree, we currently don't have a way to append pdata for > > the touchscreen. The current approach is to bail out in that case. > > This patch makes it possible to probe the touchscreen without pdata > > and use zero as default values for the atox and ato adc conversion. > Would that still make the touchscreen somehow functional ? Yes, it still works. It just defaults to zero values in no pdata case. > If that's the case, and if Dmitry is fine with the ts part of this > patch, could you please separate the mfd part of this patch into a > separate one ? Why? The purpose of this patch is to have both cases working, pdata and no pdata. This patch is actually fixing the patch of Michael Thalmeier. There we changed the mfd and touch in one patch as well. http://lkml.indiana.edu/hypermail/linux/kernel/1201.1/01364.html Thanks, Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |