From mboxrd@z Thu Jan 1 00:00:00 1970 From: Henrik Rydberg Subject: Re: [PATCH 1/2] HID: apple: Add another device ID for the mid-2013 Macbook Air Date: Sun, 25 Aug 2013 09:11:22 +0200 Message-ID: <20130825071122.GA12567@polaris.bitmath.org> References: <1377353873-17000-1-git-send-email-darkstarsword@gmail.com> <1377353873-17000-2-git-send-email-darkstarsword@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1377353873-17000-2-git-send-email-darkstarsword@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Ian Munsie Cc: Brad Ford , Linus G Thiel , Dmitry Torokhov , Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-input@vger.kernel.org Hi Ian, > This patch adds a device ID found for mid-2013 Macbook Air 6,1 from > lsusb: > > Bus 001 Device 003: ID 05ac:0290 Apple, Inc. > > Since IDs already exist for this generation Macbook air as WELLSPRING8, > name this one WELLSPRING8A. This only adds an ANSI version since it's > device ID is only one less than the existing WELLSPRING8 IDs. This seems to indicate that we got the ANSI/ISO numbers wrong in a recent patch. IIRC, there was doubt already when the patch was applied (Linus T CC'd). Most likely the right patch is this: diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c index 4ef4d5e..a73f961 100644 --- a/drivers/input/mouse/bcm5974.c +++ b/drivers/input/mouse/bcm5974.c @@ -89,9 +89,9 @@ #define USB_DEVICE_ID_APPLE_WELLSPRING7A_ISO 0x025a #define USB_DEVICE_ID_APPLE_WELLSPRING7A_JIS 0x025b /* MacbookAir6,2 (unibody, June 2013) */ -#define USB_DEVICE_ID_APPLE_WELLSPRING8_ANSI 0x0291 -#define USB_DEVICE_ID_APPLE_WELLSPRING8_ISO 0x0292 -#define USB_DEVICE_ID_APPLE_WELLSPRING8_JIS 0x0293 +#define USB_DEVICE_ID_APPLE_WELLSPRING8_ANSI 0x0290 +#define USB_DEVICE_ID_APPLE_WELLSPRING8_ISO 0x0291 +#define USB_DEVICE_ID_APPLE_WELLSPRING8_JIS 0x0292 #define BCM5974_DEVICE(prod) { \ .match_flags = (USB_DEVICE_ID_MATCH_DEVICE | \ Brad, Linus, does the above patch work for you as well as for Ian? Thanks, Henrik