linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Hutterer <peter.hutterer@who-t.net>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: linux-input@vger.kernel.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] Input: add SYN_MAX and SYN_CNT constants
Date: Thu, 29 Aug 2013 11:06:27 +1000	[thread overview]
Message-ID: <20130829010627.GA1354@yabbi.redhat.com> (raw)
In-Reply-To: <1377602632-23259-1-git-send-email-dh.herrmann@gmail.com>

On Tue, Aug 27, 2013 at 01:23:52PM +0200, David Herrmann wrote:
> SYN_* events are special and not enabled via set_bit() for devices. Hence,
> they haven't been really needed, yet. However, user-space can still make
> great use of that for int->string debugging helpers or alike.
> 
> Also, I haven't seen any reason not to define these, so here they are.
> 
> Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
> ---
>  include/uapi/linux/input.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h
> index 4649ee3..2fb6fae 100644
> --- a/include/uapi/linux/input.h
> +++ b/include/uapi/linux/input.h
> @@ -194,6 +194,8 @@ struct input_keymap_entry {
>  #define SYN_CONFIG		1
>  #define SYN_MT_REPORT		2
>  #define SYN_DROPPED		3
> +#define SYN_MAX			0xf
> +#define SYN_CNT			(SYN_MAX+1)
>  
>  /*
>   * Keys and buttons
> -- 
> 1.8.4

yes please!

Acked-by: Peter Hutterer <peter.hutterer@who-t.net>

Cheers,
   Peter


      reply	other threads:[~2013-08-29  1:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-27 11:23 [PATCH] Input: add SYN_MAX and SYN_CNT constants David Herrmann
2013-08-29  1:06 ` Peter Hutterer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130829010627.GA1354@yabbi.redhat.com \
    --to=peter.hutterer@who-t.net \
    --cc=dh.herrmann@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).