From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: David Herrmann <dh.herrmann@gmail.com>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>,
Jiri Kosina <jkosina@suse.cz>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>
Subject: Re: [GIT] HID for 3.12 merge window
Date: Fri, 6 Sep 2013 16:10:03 -0700 [thread overview]
Message-ID: <20130906231002.GA32330@core.coreip.homeip.net> (raw)
In-Reply-To: <CANq1E4Q4mxKVJJEPNSb9kvUoMXc3KoAnxjnKd0Vx+hoGaeN=kg@mail.gmail.com>
On Sat, Sep 07, 2013 at 12:51:27AM +0200, David Herrmann wrote:
> Hi
>
> On Fri, Sep 6, 2013 at 11:59 PM, Markus Trippelsdorf
> <markus@trippelsdorf.de> wrote:
> > On 2013.09.06 at 23:50 +0200, David Herrmann wrote:
> >> Hi
> >>
> >> On Fri, Sep 6, 2013 at 10:20 PM, Markus Trippelsdorf
> >> <markus@trippelsdorf.de> wrote:
> >> > On 2013.09.06 at 14:00 +0200, Jiri Kosina wrote:
> >> >>
> >> >> David Herrmann (12):
> >> > ...
> >> >> HID: wiimote: add support for Guitar-Hero drums
> >> >
> >> > commit 61e00655e9cb82e034eb72b95a51072e718d14a7
> >> > Author: David Herrmann <dh.herrmann@gmail.com>
> >> > Date: Mon Aug 26 19:14:46 2013 +0200
> >> >
> >> > Input: introduce BTN/ABS bits for drums and guitars
> >> >
> >> > The commit above breaks my Logitech mouse. The mouse cursor just sits in
> >> > the middle of the screen and doesn't react to movements. dmesg is
> >> > normal, but Xorg.0.log says:
> >>
> >> Ok, the issue is the kernel assumes ABS_MAX to be a power-of-2 minus 1
> >> (used as mask). That wasn't really obvious to me. Attached is a patch
> >> which should fix that. Could you apply it on top of linus/master and
> >> give it a try?
> >
> > Your patch fixes the issue. Thanks.
>
> Thanks a lot for reporting+testing!
>
> I am still not sure how to solve the EVIOCSABS thingy. Problem is,
> it's defined as:
> #define EVIOCSABS(_abs) ...0xc0 + (_abs)...
> But if (_abs > 0x3f) this will be bigger than 0xff. Unfortunately, the
> upper part of the ioctl is defined as 'E' which is 0x45 in hex and
> thus sets the LSB. That means we cannot extend the _IOC_TYPE field to
> the upper region (which would cause endian-issues, anyway). I guess
> we're screwed here and need to revert that...
>
> Dmitry, any comment on this? Or am I missing something?
We have gaps below ABS_MT constants, I think for 3.12 you could move
your whammy there and revert ABS_MAX change, but we need to plan for
expanding it in the future.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2013-09-06 23:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LNX.2.00.1309061202050.26934@pobox.suse.cz>
2013-09-06 20:20 ` [GIT] HID for 3.12 merge window Markus Trippelsdorf
2013-09-06 21:50 ` David Herrmann
2013-09-06 21:59 ` Markus Trippelsdorf
2013-09-06 22:51 ` David Herrmann
2013-09-06 23:10 ` Dmitry Torokhov [this message]
2013-09-06 23:57 ` Linus Torvalds
2013-09-07 0:58 ` Dmitry Torokhov
2013-09-07 1:00 ` Linus Torvalds
2013-09-07 3:22 ` Dmitry Torokhov
2013-09-07 7:31 ` David Herrmann
2013-09-07 7:32 ` David Herrmann
2013-09-07 8:24 ` Benjamin Tissoires
2013-09-07 8:57 ` David Herrmann
[not found] ` <522AEFE9.30402@gmail.com>
2013-09-07 9:29 ` David Herrmann
2013-09-07 17:12 ` Dmitry Torokhov
2013-09-07 16:52 ` Linus Torvalds
2013-09-07 17:31 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130906231002.GA32330@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=dh.herrmann@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).