From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?q?J=FCrgen_Beisert?= Subject: Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection Date: Mon, 16 Sep 2013 16:34:54 +0200 Message-ID: <201309161634.54603.jbe@pengutronix.de> References: <1378887511-24530-1-git-send-email-jbe@pengutronix.de> <201309161010.22151.jbe@pengutronix.de> <201309161623.48247.marex@denx.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <201309161623.48247.marex-ynQEQJNshbs@public.gmane.org> Content-Disposition: inline Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Marek Vasut Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jonathan Cameron , linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org, jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org, Torokhov , "linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Otavio Salvador List-Id: linux-input@vger.kernel.org Hi Marek, On Monday 16 September 2013 16:23:48 Marek Vasut wrote: > > On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote: > > > On 09/11/13 09:18, Juergen Beisert wrote: > > > > For battery driven systems it is a very bad idea to collect the > > > > touchscreen data within a kernel busy loop. > > > > > > > > This change uses the features of the hardware to delay and accu= mulate > > > > samples in hardware to avoid a high interrupt and CPU load. > > > > > > > > Note: this is only tested on an i.MX23 SoC yet. > > > > > > > > Signed-off-by: Juergen Beisert > > > > CC: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > > > > CC: devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org > > > > CC: Marek Vasut > > > > CC: Fabio Estevam > > > > CC: Jonathan Cameron > > > > > > While this driver is placed in IIO within staging at the moment, = these > > > changes are definitely input related. Hence I have cc'd Dmitry a= nd the > > > input list. > > > > > > I am personaly a little uncomfortable that we have such a complex= bit > > > of input code sat within an IIO driver but such is life. > > > > Maybe an MFD for this ADC unit would be a better way to go? Current= ly I > > have a different problem with this driver, because the ADC unit mon= itors > > the battery as well. And the charging driver from the power subsyst= em > > needs these values to charge the battery in a correct manner. > > Are you planning to post the power block patches too ? When they will work: yes. Currently it crashes all the time. The PMIC i= s a=20 beast... Regards, Juergen --=20 Pengutronix e.K. =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0| Juergen Beisert =A0 =A0 =A0 =A0 =A0 =A0 | Linux Solutions for Science and Industry =A0 =A0 =A0| http://www.pengut= ronix.de/ |