From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-input@vger.kernel.org, michael.hennerich@analog.com,
Barry Song <21cnbao@gmail.com>
Subject: Re: [PATCH 1/4] Input: ad714x-spi - Remove redundant spi_set_drvdata
Date: Fri, 20 Sep 2013 09:39:38 -0700 [thread overview]
Message-ID: <20130920163938.GA6300@core.coreip.homeip.net> (raw)
In-Reply-To: <1379652173-32477-1-git-send-email-sachin.kamat@linaro.org>
On Fri, Sep 20, 2013 at 10:12:50AM +0530, Sachin Kamat wrote:
> Driver core sets driver data to NULL upon failure or remove.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Barry Song <21cnbao@gmail.com>
> ---
> Series compile tested.
Applied all 4, thank you.
> ---
> drivers/input/misc/ad714x-spi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/misc/ad714x-spi.c b/drivers/input/misc/ad714x-spi.c
> index 6189148..3a90b71 100644
> --- a/drivers/input/misc/ad714x-spi.c
> +++ b/drivers/input/misc/ad714x-spi.c
> @@ -108,7 +108,6 @@ static int ad714x_spi_remove(struct spi_device *spi)
> struct ad714x_chip *chip = spi_get_drvdata(spi);
>
> ad714x_remove(chip);
> - spi_set_drvdata(spi, NULL);
>
> return 0;
> }
> --
> 1.7.9.5
>
--
Dmitry
prev parent reply other threads:[~2013-09-20 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 4:42 [PATCH 1/4] Input: ad714x-spi - Remove redundant spi_set_drvdata Sachin Kamat
2013-09-20 4:42 ` [PATCH 2/4] Input: ad7877 " Sachin Kamat
2013-09-20 16:39 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130920163938.GA6300@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=21cnbao@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).