* [PATCH 1/4] Input: ad714x-spi - Remove redundant spi_set_drvdata
@ 2013-09-20 4:42 Sachin Kamat
2013-09-20 4:42 ` [PATCH 2/4] Input: ad7877 " Sachin Kamat
2013-09-20 16:39 ` [PATCH 1/4] Input: ad714x-spi " Dmitry Torokhov
0 siblings, 2 replies; 3+ messages in thread
From: Sachin Kamat @ 2013-09-20 4:42 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, michael.hennerich, sachin.kamat, Barry Song
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Barry Song <21cnbao@gmail.com>
---
Series compile tested.
---
drivers/input/misc/ad714x-spi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/misc/ad714x-spi.c b/drivers/input/misc/ad714x-spi.c
index 6189148..3a90b71 100644
--- a/drivers/input/misc/ad714x-spi.c
+++ b/drivers/input/misc/ad714x-spi.c
@@ -108,7 +108,6 @@ static int ad714x_spi_remove(struct spi_device *spi)
struct ad714x_chip *chip = spi_get_drvdata(spi);
ad714x_remove(chip);
- spi_set_drvdata(spi, NULL);
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/4] Input: ad7877 - Remove redundant spi_set_drvdata
2013-09-20 4:42 [PATCH 1/4] Input: ad714x-spi - Remove redundant spi_set_drvdata Sachin Kamat
@ 2013-09-20 4:42 ` Sachin Kamat
2013-09-20 16:39 ` [PATCH 1/4] Input: ad714x-spi " Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Sachin Kamat @ 2013-09-20 4:42 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, michael.hennerich, sachin.kamat
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/input/touchscreen/ad7877.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c
index f3a174a..69834dd 100644
--- a/drivers/input/touchscreen/ad7877.c
+++ b/drivers/input/touchscreen/ad7877.c
@@ -806,7 +806,6 @@ err_free_irq:
err_free_mem:
input_free_device(input_dev);
kfree(ts);
- spi_set_drvdata(spi, NULL);
return err;
}
@@ -823,7 +822,6 @@ static int ad7877_remove(struct spi_device *spi)
kfree(ts);
dev_dbg(&spi->dev, "unregistered touchscreen\n");
- spi_set_drvdata(spi, NULL);
return 0;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/4] Input: ad714x-spi - Remove redundant spi_set_drvdata
2013-09-20 4:42 [PATCH 1/4] Input: ad714x-spi - Remove redundant spi_set_drvdata Sachin Kamat
2013-09-20 4:42 ` [PATCH 2/4] Input: ad7877 " Sachin Kamat
@ 2013-09-20 16:39 ` Dmitry Torokhov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2013-09-20 16:39 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-input, michael.hennerich, Barry Song
On Fri, Sep 20, 2013 at 10:12:50AM +0530, Sachin Kamat wrote:
> Driver core sets driver data to NULL upon failure or remove.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Barry Song <21cnbao@gmail.com>
> ---
> Series compile tested.
Applied all 4, thank you.
> ---
> drivers/input/misc/ad714x-spi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/misc/ad714x-spi.c b/drivers/input/misc/ad714x-spi.c
> index 6189148..3a90b71 100644
> --- a/drivers/input/misc/ad714x-spi.c
> +++ b/drivers/input/misc/ad714x-spi.c
> @@ -108,7 +108,6 @@ static int ad714x_spi_remove(struct spi_device *spi)
> struct ad714x_chip *chip = spi_get_drvdata(spi);
>
> ad714x_remove(chip);
> - spi_set_drvdata(spi, NULL);
>
> return 0;
> }
> --
> 1.7.9.5
>
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-20 16:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-20 4:42 [PATCH 1/4] Input: ad714x-spi - Remove redundant spi_set_drvdata Sachin Kamat
2013-09-20 4:42 ` [PATCH 2/4] Input: ad7877 " Sachin Kamat
2013-09-20 16:39 ` [PATCH 1/4] Input: ad714x-spi " Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).