From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Manish Badarkhe <badarkhe.manish@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
josh.wu@atmel.com
Subject: Re: [PATCH] Input: atmel_tscadcc - update to devm_* API
Date: Fri, 20 Sep 2013 10:01:35 -0700 [thread overview]
Message-ID: <20130920170135.GB6300@core.coreip.homeip.net> (raw)
In-Reply-To: <1379343178-6468-1-git-send-email-badarkhe.manish@gmail.com>
Hi Manish,
On Mon, Sep 16, 2013 at 08:22:58PM +0530, Manish Badarkhe wrote:
> static int atmel_tsadcc_remove(struct platform_device *pdev)
> {
> struct atmel_tsadcc *ts_dev = platform_get_drvdata(pdev);
> - struct resource *res;
> -
> - free_irq(ts_dev->irq, ts_dev);
>
> input_unregister_device(ts_dev->input);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - iounmap(tsc_base);
> - release_mem_region(res->start, resource_size(res));
> -
> clk_disable(ts_dev->clk);
> - clk_put(ts_dev->clk);
> -
> - kfree(ts_dev);
>
> return 0;
> }
By doing this conversion we disable the clock too early. I need to
resurrect my patches to add devm_clk_enable and then we can revisit this
patch.
Thanks.
--
Dmitry
prev parent reply other threads:[~2013-09-20 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 14:52 [PATCH] Input: atmel_tscadcc - update to devm_* API Manish Badarkhe
2013-09-20 17:01 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130920170135.GB6300@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=badarkhe.manish@gmail.com \
--cc=josh.wu@atmel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).