From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input: atmel_tscadcc - update to devm_* API Date: Fri, 20 Sep 2013 10:01:35 -0700 Message-ID: <20130920170135.GB6300@core.coreip.homeip.net> References: <1379343178-6468-1-git-send-email-badarkhe.manish@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pb0-f52.google.com ([209.85.160.52]:57649 "EHLO mail-pb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752798Ab3ITRBr (ORCPT ); Fri, 20 Sep 2013 13:01:47 -0400 Content-Disposition: inline In-Reply-To: <1379343178-6468-1-git-send-email-badarkhe.manish@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Manish Badarkhe Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, josh.wu@atmel.com Hi Manish, On Mon, Sep 16, 2013 at 08:22:58PM +0530, Manish Badarkhe wrote: > static int atmel_tsadcc_remove(struct platform_device *pdev) > { > struct atmel_tsadcc *ts_dev = platform_get_drvdata(pdev); > - struct resource *res; > - > - free_irq(ts_dev->irq, ts_dev); > > input_unregister_device(ts_dev->input); > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - iounmap(tsc_base); > - release_mem_region(res->start, resource_size(res)); > - > clk_disable(ts_dev->clk); > - clk_put(ts_dev->clk); > - > - kfree(ts_dev); > > return 0; > } By doing this conversion we disable the clock too early. I need to resurrect my patches to add devm_clk_enable and then we can revisit this patch. Thanks. -- Dmitry