From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup Date: Fri, 27 Sep 2013 18:24:12 +0300 Message-ID: <20130927152412.GF6192@mwanda> References: <5237430B.5040009@canonical.com> <20130916203824.GP25896@mwanda> <52376ED9.5080208@canonical.com> <20130916210503.GQ25896@mwanda> <5237A5D5.8010006@canonical.com> <52432152.3030100@canonical.com> <52459942.3020600@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <52459942.3020600@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: driverdev-devel-bounces@linuxdriverproject.org To: Joseph Salisbury Cc: list@osuosl.org, Jiri Kosina , Haiyang Zhang , LKML , open@osuosl.org, HID CORE LAYER , devel@linuxdriverproject.org, thomas@m3y3r.de List-Id: linux-input@vger.kernel.org On Fri, Sep 27, 2013 at 10:42:10AM -0400, Joseph Salisbury wrote: > On 09/27/2013 06:50 AM, Jiri Kosina wrote: > > On Wed, 25 Sep 2013, Joseph Salisbury wrote: > > > >> After further testing reverting the following commit does in fact > >> resolve the bug: > >> > >> commit b1a1442a23776756b254b69786848a94d92445ba > >> Author: Jiri Kosina > >> Date: Mon Jun 3 11:27:48 2013 +0200 > >> > >> HID: core: fix reporting of raw events > >> > >> Reverting this commit in v3.12-rc2 prevents the system from locking up, > >> which happens when connecting a bluetooth trackpad. > >> > >> Jiri, do you think we should revert this patch, or is there some further > >> debugging/data collecting you would like to do? > > Hi Joseph, > > > > in this mail: > > > > Message-ID: <5241992E.3090805@canonical.com> > > Date: Tue, 24 Sep 2013 09:52:46 -0400 > > > > you said that reverting this commit doesn't prevent the lockups, so I am > > rather confused ... ? > > > > Thanks, > > > The testing was invalid. Reverting commit b1a1442 does resolve the bug > and stop the lockups. > It looks like magicmouse_raw_event() returns 1 on success and 0 on failure. regards, dan carpenter