From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: list@osuosl.org, Haiyang Zhang <haiyangz@microsoft.com>,
LKML <linux-kernel@vger.kernel.org>,
open@osuosl.org, thomas@m3y3r.de,
HID CORE LAYER <linux-input@vger.kernel.org>,
devel@linuxdriverproject.org,
Joseph Salisbury <joseph.salisbury@canonical.com>
Subject: Re: [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup
Date: Mon, 30 Sep 2013 17:59:39 +0300 [thread overview]
Message-ID: <20130930145939.GK6192@mwanda> (raw)
In-Reply-To: <alpine.LNX.2.00.1309301634260.28935@pobox.suse.cz>
On Mon, Sep 30, 2013 at 04:35:47PM +0200, Jiri Kosina wrote:
> On Fri, 27 Sep 2013, Dan Carpenter wrote:
>
> > It looks like magicmouse_raw_event() returns 1 on success and 0 on
> > failure.
>
> Good catch indeed.
>
> I am not completely sure whether we are going to fix an oops or not by
> this, as I haven't seen the actual oops anywhere in this thread :) But
> definitely this looks like a good fix.
>
> Joseph, could you please test with that? Thanks.
In the new code both 0 and 1 are treated the same so this can't fix the
bug.
regards,
dan carpenter
next prev parent reply other threads:[~2013-09-30 14:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 17:42 [v3.11][Regression] HID: hyperv: convert alloc+memcpy to memdup Joseph Salisbury
2013-09-16 20:38 ` Dan Carpenter
2013-09-16 20:49 ` Joseph Salisbury
2013-09-16 21:05 ` Dan Carpenter
2013-09-17 0:44 ` Joseph Salisbury
2013-09-24 9:29 ` Jiri Kosina
2013-09-24 13:52 ` Joseph Salisbury
2013-09-24 18:25 ` Joseph Salisbury
2013-09-25 17:45 ` Joseph Salisbury
2013-09-27 10:50 ` Jiri Kosina
2013-09-27 14:42 ` Joseph Salisbury
2013-09-27 15:24 ` Dan Carpenter
2013-09-27 15:59 ` Dan Carpenter
2013-09-30 14:35 ` Jiri Kosina
2013-09-30 14:59 ` Dan Carpenter [this message]
2013-12-16 13:01 ` Jiri Kosina
2013-12-19 9:55 ` David Herrmann
2013-12-19 9:59 ` Jiri Kosina
2013-12-19 10:08 ` David Herrmann
2013-12-19 11:22 ` David Herrmann
2013-12-19 12:59 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130930145939.GK6192@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jkosina@suse.cz \
--cc=joseph.salisbury@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=list@osuosl.org \
--cc=open@osuosl.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).