From: Sebastian Reichel <sre@debian.org>
To: Rob Herring <robherring2@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Sachin Kamat <sachin.kamat@linaro.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCHv5 1/3] Input: twl4030-pwrbutton - add device tree support
Date: Thu, 24 Oct 2013 00:49:42 +0200 [thread overview]
Message-ID: <20131023224940.GA19522@earth.universe> (raw)
In-Reply-To: <52684C8E.6080802@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]
On Wed, Oct 23, 2013 at 05:24:14PM -0500, Rob Herring wrote:
> So a twl4030 device is only a power button? DT should describe the h/w
> not a node for a sub-function of a device.
No. TWL4030 is a companion chip for the OMAP3 processor. It provides
miscellaneous functionality, e.g.:
* RTC
* Watchdog
* Regulators
* Keypad Matrix
* USB
* Audio
* Vibrator
* GPIO
* ...
One part of the functionality is the power button. The patch
assumes, that the twl4030-pwrbutton node is used as follows:
twl {
/* ... common stuff ... */
pwrbutton {
compatible = "ti,twl4030-pwrbutton";
interrupts = <8>;
};
};
See also:
* Documentation/devicetree/bindings/mfd/twl-familly.txt
* Documentation/devicetree/bindings/watchdog/twl4030-wdt.txt
* Documentation/devicetree/bindings/sound/omap-twl4030.txt
* Documentation/devicetree/bindings/mfd/twl4030-power.txt
* Documentation/devicetree/bindings/mfd/twl4030-audio.txt
* Documentation/devicetree/bindings/gpio/gpio-twl4030.txt
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-10-23 22:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 20:26 [PATCHv5 0/3] DT Support for TWL4030 power button Sebastian Reichel
2013-10-23 20:26 ` [PATCHv5 1/3] Input: twl4030-pwrbutton - add device tree support Sebastian Reichel
[not found] ` <1382560002-6299-2-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2013-10-23 22:24 ` Rob Herring
2013-10-23 22:49 ` Sebastian Reichel [this message]
2013-10-25 19:40 ` Grant Likely
2013-10-23 20:26 ` [PATCHv5 2/3] Input: twl4030-pwrbutton: use dev_err for errors Sebastian Reichel
2013-10-23 20:26 ` [PATCHv5 3/3] Input: twl4030-pwrbutton: simplify driver using devm_* Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131023224940.GA19522@earth.universe \
--to=sre@debian.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).