From: "Eric Bénard" <eric@eukrea.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: "Denis Carikli" <denis@eukrea.com>,
"Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Pawel Moll" <pawel.moll@arm.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Rob Herring" <rob.herring@calxeda.com>,
"Grant Likely" <grant.likely@secretlab.ca>,
"Sascha Hauer" <kernel@pengutronix.de>,
linux-input@vger.kernel.org, "Shawn Guo" <shawn.guo@linaro.org>,
linux-arm-kernel@lists.infradead.org,
"Lothar Waßmann" <LW@KARO-electronics.de>
Subject: Re: [PATCHv7][ 1/4] Input: tsc2007: Add device tree support.
Date: Thu, 24 Oct 2013 17:26:44 +0200 [thread overview]
Message-ID: <20131024172644.45816152@e6520eb> (raw)
In-Reply-To: <20131024151736.GE9044@ulmo.nvidia.com>
Hi Thierry,
Le Thu, 24 Oct 2013 17:17:37 +0200,
Thierry Reding <thierry.reding@gmail.com> a écrit :
> > +- ti,max-rt: maximum pressure.
> > +- ti,fuzzy: specifies the absolute input fuzz value.
> > + If set, it will permit noise in the data up to +- the value given to the fuzz
> > + parameter, that is used to filter noise from the event stream.
>
> Any reason why these can't be specified per axis? From my experience
> with this chip it can make sense to use different values for the
> different axes. Well, perhaps X and Y axes can share one fuzz factor,
> but the Z axis is sometimes different.
>
> You also modify the driver to ignore the X and Z axes fuzz factor even
> for platform data where specifying all three separately was explicitly
> allowed. Have you verified that this doesn't cause any regressions?
>
That was not intended, that's an error, we will fix that.
Thanks,
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-10-24 15:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 12:42 [PATCHv7][ 1/4] Input: tsc2007: Add device tree support Denis Carikli
2013-10-24 12:42 ` [PATCHv7][ 2/4] ARM: dts: cpuimx51 Add touchscreen support Denis Carikli
2013-10-24 12:42 ` [PATCHv7][ 3/4] ARM: dts: cpuimx35 " Denis Carikli
2013-10-24 12:42 ` [PATCHv7][ 4/4] ARM: imx_v6_v7_defconfig: Enable tsc2007 support Denis Carikli
2013-10-24 15:17 ` [PATCHv7][ 1/4] Input: tsc2007: Add device tree support Thierry Reding
2013-10-24 15:26 ` Eric Bénard [this message]
2013-10-25 6:39 ` Lothar Waßmann
2013-10-25 8:33 ` Thierry Reding
2013-11-04 12:01 ` Linus Walleij
2013-10-24 16:47 ` Grant Likely
2013-10-25 5:56 ` Lothar Waßmann
2013-10-25 19:11 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131024172644.45816152@e6520eb \
--to=eric@eukrea.com \
--cc=LW@KARO-electronics.de \
--cc=denis@eukrea.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=shawn.guo@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).