linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Mark Brown <broonie@kernel.org>
Cc: linux-fbdev@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	linux-mtd@lists.infradead.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Vinod Koul <vinod.koul@intel.com>, Joerg Roedel <joro@8bytes.org>,
	linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
	Eduardo Valentin <eduardo.valentin@ti.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	linux-serial@vger.kernel.org, linux-input@vger.kernel.org,
	Zhang Rui <rui.zhang@intel.com>, Chris Ball <cjb@laptop.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	linux-media@vger.kernel.org, linux-pwm@vger.kernel.org,
	Samuel Ortiz <samuel@sortiz.org>,
	linux-pm@vger.kernel.org, Ian Molton <ian@mne>
Subject: Re: [PATCH 00/19] Enable various Renesas drivers on all ARM platforms
Date: Wed, 30 Oct 2013 09:05:03 +0900	[thread overview]
Message-ID: <20131030000501.GE21262@verge.net.au> (raw)
In-Reply-To: <20131029175834.GD20251@sirena.org.uk>

On Tue, Oct 29, 2013 at 10:58:34AM -0700, Mark Brown wrote:
> On Tue, Oct 29, 2013 at 06:29:59PM +0100, Laurent Pinchart wrote:
> > On Tuesday 29 October 2013 10:23:31 Mark Brown wrote:
> > > On Tue, Oct 29, 2013 at 06:05:53PM +0100, Laurent Pinchart wrote:
> > > > The first one is that I can't compile-test all those drivers on all
> > > > architectures. The spi-sh-msiof driver, for instance, uses
> > > > io(read|write)(16|
> 
> > > Which architectures are these and is there not a symbol we can depend on
> > > for them?
> 
> > arch/cris for instance. We can use readl/writel instead (maybe it would be 
> > time to rationalize and document the I/O accessors across all architectures, 
> > but that's another topic).
> 
> It'd certainly be sensible, or adding a config option to depend on if
> you rely on these functions.
> 
> > My point is that there might be other issues that I won't be able to easily 
> > catch. This would break compilation for everybody for no reason, as the 
> > drivers are useless on non-SuperH, non-ARM platforms. That's why I believe 
> > COMPILE_TEST would be a better option as a first step.
> 
> Yes, it would - please do that.  Note that it won't stop anyone running
> into build issues on other architectures though, it's just about
> stopping Kconfig noise.

FWIW, I am happy with using COMPILE_TEST for this series.

  reply	other threads:[~2013-10-30  0:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-28 23:46 [PATCH 00/19] Enable various Renesas drivers on all ARM platforms Laurent Pinchart
2013-10-28 23:46 ` [PATCH 04/19] input: sh_keysc: Enable the driver " Laurent Pinchart
2013-10-29  6:04 ` [PATCH 00/19] Enable various Renesas drivers " Simon Horman
2013-10-29 16:04   ` Mark Brown
     [not found]     ` <20131029160449.GD16686-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-10-29 17:05       ` Laurent Pinchart
2013-10-29 17:23         ` Mark Brown
     [not found]           ` <20131029172331.GA20251-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-10-29 17:29             ` Laurent Pinchart
2013-10-29 17:58               ` Mark Brown
2013-10-30  0:05                 ` Simon Horman [this message]
2013-10-30 10:59                   ` Tomi Valkeinen
2013-10-29  9:12 ` Guennadi Liakhovetski
     [not found]   ` <Pine.LNX.4.64.1310291009121.8404-0199iw4Nj15frtckUFj5Ag@public.gmane.org>
2013-10-29  9:46     ` Laurent Pinchart
2013-10-29 13:06   ` Artem Bityutskiy
     [not found]     ` <1383051980.29619.33.camel-Bxnoe/o8FG+Ef9UqXRslZEEOCMrvLtNR@public.gmane.org>
2013-10-29 13:22       ` Laurent Pinchart
2013-10-29 13:54         ` Artem Bityutskiy
2013-10-29 16:28 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131030000501.GE21262@verge.net.au \
    --to=horms@verge.net.au \
    --cc=broonie@kernel.org \
    --cc=cjb@laptop.org \
    --cc=eduardo.valentin@ti.com \
    --cc=g.liakhovetski+renesas@gmail.com \
    --cc=ian@mne \
    --cc=joro@8bytes.org \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=rui.zhang@intel.com \
    --cc=samuel@sortiz.org \
    --cc=thierry.reding@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=vinod.koul@intel.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).