From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Daniel Stone <daniel@fooishbar.org>
Cc: linux-input@vger.kernel.org, Henrik Rydberg <rydberg@euromail.se>
Subject: Re: [PATCH] Input: evdev: Fall back to vmalloc for client event buffer
Date: Thu, 31 Oct 2013 00:26:06 -0700 [thread overview]
Message-ID: <20131031072606.GA14057@core.coreip.homeip.net> (raw)
In-Reply-To: <1381151213-32690-1-git-send-email-daniels@collabora.com>
On Mon, Oct 07, 2013 at 02:06:53PM +0100, Daniel Stone wrote:
> evdev always tries to allocate the event buffer for clients using
> kzalloc rather than vmalloc, presumably to avoid mapping overhead where
> possible. However, drivers like bcm5974, which claims support for
> reporting 16 fingers simultaneously, can have an extraordinarily large
> buffer. The resultant contiguous order-4 allocation attempt fails due
> to fragmentation, and the device is thus unusable until reboot.
>
> Try kzalloc if we can to avoid the mapping overhead, but if that fails,
> fall back to vzalloc.
>
> Signed-off-by: Daniel Stone <daniels@collabora.com>
Applied, thank you Daniel.
--
Dmitry
prev parent reply other threads:[~2013-10-31 7:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 13:06 [PATCH] Input: evdev: Fall back to vmalloc for client event buffer Daniel Stone
2013-10-28 11:50 ` Daniel Stone
2013-10-31 7:26 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031072606.GA14057@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=daniel@fooishbar.org \
--cc=linux-input@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).